[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/6] tests: respect --enable/--disable-download for Avocado
|
From: |
Paolo Bonzini |
|
Subject: |
[PULL 2/6] tests: respect --enable/--disable-download for Avocado |
|
Date: |
Sat, 11 Nov 2023 16:29:19 +0100 |
Pass the content of $mkvenv_flags (which is either "--online"
or empty) down to tests/Makefile.include.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 9 +++++----
tests/Makefile.include | 2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index abcb199aa87..2da3c278db6 100755
--- a/configure
+++ b/configure
@@ -968,14 +968,14 @@ meson="$(cd pyvenv/bin; pwd)/meson"
# Conditionally ensure Sphinx is installed.
-mkvenv_flags=""
-if test "$download" = "enabled" -a "$docs" = "enabled" ; then
- mkvenv_flags="--online"
+mkvenv_online_flag=""
+if test "$download" = "enabled" ; then
+ mkvenv_online_flag=" --online"
fi
if test "$docs" != "disabled" ; then
if ! $mkvenv ensuregroup \
- $mkvenv_flags \
+ $(test "$docs" = "enabled" && echo "$mkvenv_online_flag") \
${source_path}/pythondeps.toml docs;
then
if test "$docs" = "enabled" ; then
@@ -1631,6 +1631,7 @@ if test "$container" != no; then
fi
echo "SUBDIRS=$subdirs" >> $config_host_mak
echo "PYTHON=$python" >> $config_host_mak
+echo "MKVENV_ENSUREGROUP=$mkvenv ensuregroup $mkvenv_online_flag" >>
$config_host_mak
echo "GENISOIMAGE=$genisoimage" >> $config_host_mak
echo "MESON=$meson" >> $config_host_mak
echo "NINJA=$ninja" >> $config_host_mak
diff --git a/tests/Makefile.include b/tests/Makefile.include
index dab1989a071..c9d1674bd07 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -111,7 +111,7 @@ quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \
$(TESTS_VENV_TOKEN): $(SRC_PATH)/pythondeps.toml
$(call quiet-venv-pip,install -e "$(SRC_PATH)/python/")
- $(PYTHON) python/scripts/mkvenv.py ensuregroup --online $< avocado
+ $(MKVENV_ENSUREGROUP) $< avocado
$(call quiet-command, touch $@)
$(TESTS_RESULTS_DIR):
--
2.41.0
- [PULL 0/6] Biuld system and CI changes for 2023-11-10, Paolo Bonzini, 2023/11/11
- [PULL 1/6] coverity: physmem: use simple assertions instead of modelling, Paolo Bonzini, 2023/11/11
- [PULL 2/6] tests: respect --enable/--disable-download for Avocado,
Paolo Bonzini <=
- [PULL 3/6] docs: document what configure does with virtual environments, Paolo Bonzini, 2023/11/11
- [PULL 4/6] buildsys: Bump known good meson version to v1.2.3, Paolo Bonzini, 2023/11/11
- [PULL 5/6] .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura), Paolo Bonzini, 2023/11/11
- [PULL 6/6] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma), Paolo Bonzini, 2023/11/11
- Re: [PULL 0/6] Biuld system and CI changes for 2023-11-10, Stefan Hajnoczi, 2023/11/12