Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

[Robert Hoo]

On 11/13/2023 6:05 PM, Philippe Mathieu-Daudé wrote:
> Hi Robert,
>
> On 13/11/23 09:13, Robert Hoo wrote:
> > In the rollback in msix_set_vector_notifiers(), original patch forgot to
> > undo msix_vector_poll_notifier pointer.
>
> Out of curiosity, nobody complained during 11 years, so in which
> use case did you notice this?

Hi Philippe,

I stumbled upon this when looking into another issue.

I think, thanks to the caller's very standardized use, the omission has never 
been exposed.