[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/12] target/hppa: Fix possible overflow in TLB size calculation
|
From: |
Richard Henderson |
|
Subject: |
[PULL 05/12] target/hppa: Fix possible overflow in TLB size calculation |
|
Date: |
Mon, 13 Nov 2023 09:32:30 -0800 |
From: Helge Deller <deller@gmx.de>
Coverty found that the shift of TARGET_PAGE_SIZE (32-bit type) might
overflow. Fix it by casting TARGET_PAGE_SIZE to a 64-bit type before
doing the shift (CID 1523902 and CID 1523908).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Helge Deller <deller@gmx.de>
Message-Id: <ZU6F/H8CZr3q4pP/@p100>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hppa/mem_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index 858ce6ec7f..a13f200359 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -450,7 +450,7 @@ static void itlbt_pa20(CPUHPPAState *env, target_ulong r1,
int mask_shift;
mask_shift = 2 * (r1 & 0xf);
- va_size = TARGET_PAGE_SIZE << mask_shift;
+ va_size = (uint64_t)TARGET_PAGE_SIZE << mask_shift;
va_b &= -va_size;
va_e = va_b + va_size - 1;
@@ -505,7 +505,7 @@ static void ptlb_work(CPUState *cpu, run_on_cpu_data data)
*/
end = start & 0xf;
start &= TARGET_PAGE_MASK;
- end = TARGET_PAGE_SIZE << (2 * end);
+ end = (vaddr)TARGET_PAGE_SIZE << (2 * end);
end = start + end - 1;
hppa_flush_tlb_range(env, start, end);
--
2.34.1
- [PULL 00/12] target/hppa: last minute hppa64 fixes, Richard Henderson, 2023/11/13
- [PULL 04/12] target/hppa: Fix calculation of CR_IIASQ back register, Richard Henderson, 2023/11/13
- [PULL 03/12] target/hppa: Use PRIV_P_TO_MMU_IDX in helper_probe, Richard Henderson, 2023/11/13
- [PULL 02/12] target/hppa: Use only low 2 immediate bits for PROBEI, Richard Henderson, 2023/11/13
- [PULL 06/12] target/hppa: Introduce MMU_IDX_MMU_DISABLED, Richard Henderson, 2023/11/13
- [PULL 08/12] target/hppa: Reduce TARGET_PHYS_ADDR_SPACE_BITS to 40, Richard Henderson, 2023/11/13
- [PULL 01/12] target/hppa: Mask reserved PSW bits in expand_sm_imm, Richard Henderson, 2023/11/13
- [PULL 12/12] hw/hppa: Require at least SeaBIOS-hppa version 12, Richard Henderson, 2023/11/13
- [PULL 07/12] target/hppa: Replace MMU_PHYS_IDX with MMU_ABS_IDX, MMU_ABS_W_IDX, Richard Henderson, 2023/11/13
- [PULL 10/12] hw/hppa: Move software power button address to page zero, Richard Henderson, 2023/11/13
- [PULL 05/12] target/hppa: Fix possible overflow in TLB size calculation,
Richard Henderson <=
- [PULL 09/12] hw/pci-host/astro: Fix boot for C3700 machine, Richard Henderson, 2023/11/13
- [PULL 11/12] target/hppa: Update to SeaBIOS-hppa from version 10 to 12, Richard Henderson, 2023/11/13
- Re: [PULL 00/12] target/hppa: last minute hppa64 fixes, Stefan Hajnoczi, 2023/11/14