[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/4] target/arm: HVC at EL3 should go to EL3, not EL2
|
From: |
Peter Maydell |
|
Subject: |
[PULL 2/4] target/arm: HVC at EL3 should go to EL3, not EL2 |
|
Date: |
Mon, 13 Nov 2023 17:46:33 +0000 |
AArch64 permits code at EL3 to use the HVC instruction; however the
exception we take should go to EL3, not down to EL2 (see the pseudocode
AArch64.CallHypervisor()). Fix the target EL.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>
Message-id: 20231109151917.1925107-1-peter.maydell@linaro.org
---
target/arm/tcg/translate-a64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 41484d8ae54..a2e49c39f9f 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -2351,6 +2351,8 @@ static bool trans_SVC(DisasContext *s, arg_i *a)
static bool trans_HVC(DisasContext *s, arg_i *a)
{
+ int target_el = s->current_el == 3 ? 3 : 2;
+
if (s->current_el == 0) {
unallocated_encoding(s);
return true;
@@ -2363,7 +2365,7 @@ static bool trans_HVC(DisasContext *s, arg_i *a)
gen_helper_pre_hvc(tcg_env);
/* Architecture requires ss advance before we do the actual work */
gen_ss_advance(s);
- gen_exception_insn_el(s, 4, EXCP_HVC, syn_aa64_hvc(a->imm), 2);
+ gen_exception_insn_el(s, 4, EXCP_HVC, syn_aa64_hvc(a->imm), target_el);
return true;
}
--
2.34.1
- [PULL 0/4] target-arm queue, Peter Maydell, 2023/11/13
- [PULL 1/4] hw/arm/virt: fix GIC maintenance IRQ registration, Peter Maydell, 2023/11/13
- [PULL 4/4] target/arm/tcg: enable PMU feature for Cortex-A8 and A9, Peter Maydell, 2023/11/13
- [PULL 3/4] target/arm: Correct MTE tag checking for reverse-copy MOPS, Peter Maydell, 2023/11/13
- [PULL 2/4] target/arm: HVC at EL3 should go to EL3, not EL2,
Peter Maydell <=
- Re: [PULL 0/4] target-arm queue, Stefan Hajnoczi, 2023/11/14