Re: [PATCH] tests/avocado/replay_kernel: Mark the test_x86_64_pc as flaky

[Peter Maydell]

On Tue, 14 Nov 2023 at 15:30, Thomas Huth <thuth@redhat.com> wrote:
>
> It's failing very often, so don't run this by default anymore
> until it gets fixed.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/avocado/replay_kernel.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py
> index a18610542e..53cb7e5091 100644
> --- a/tests/avocado/replay_kernel.py
> +++ b/tests/avocado/replay_kernel.py
> @@ -81,7 +81,8 @@ def run_rr(self, kernel_path, kernel_command_line, 
> console_pattern,
>          logger.info('replay overhead {:.2%}'.format(t2 / t1 - 1))
>
>  class ReplayKernelNormal(ReplayKernelBase):
> -    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> +
> +    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test sometimes gets 
> stuck')
>      def test_x86_64_pc(self):
>          """
>          :avocado: tags=arch:x86_64

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

We should replace all of the "skip if GITLAB_CI" checks
with "skip on QEMU_TEST_FLAKY_TESTS" (or other check as
appropriate), I think.

thanks
-- PMM