[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes
|
From: |
Volodymyr Babchuk |
|
Subject: |
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes |
|
Date: |
Tue, 14 Nov 2023 21:32:05 +0000 |
|
User-agent: |
mu4e 1.10.7; emacs 29.1 |
Hi David,
David Woodhouse <dwmw2@infradead.org> writes:
> On 11 November 2023 16:51:22 GMT-05:00, Andrew Cooper
> <andrew.cooper3@citrix.com> wrote:
>>On 11/11/2023 8:18 pm, David Woodhouse wrote:
>>> On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper
>>> <andrew.cooper3@citrix.com> wrote:
>>>> Furthermore, the control domain doesn't always have the domid of 0.
>>>>
>>>> If qemu wants/needs to make changes like this, the control domain has to
>>>> arrange for qemu's domain to have appropriate permissions on the nodes.
>>> Right. And that's simple enough: if you are running QEMU in a
>>> domain which doesn't have permission to create the backend
>>> directory and/or the frontend nodes, don't ask it to *create*
>>> devices. In that case it is only able to connect as the backend for
>>> devices which were created *for* it by the toolstack.
>>>
>>> The criterion used in this patch series should be "did QEMU create this
>>> device, or discover it".
>>>
>>
>>Yeah, that sounds like the right approach.
>
> I think we want to kill the xen_backend_set_device() function and
> instead set the backend as a property of the XenDevice *before*
> realizing it.
Not sure that I got this. Right now device is property of
XenBackendInstance. Are you proposing to make this other way around?
Right now I am looking for a place where to store the information of
XenDevice creator. My plan was to add "found_in_xenbus" property to
XenDevice and set it in xen_backend_device_create.
--
WBR, Volodymyr
- [PATCH v1 6/7] xen_arm: Set mc->max_cpus to GUEST_MAX_VCPUS in xen_arm_init(), (continued)
- [PATCH v1 6/7] xen_arm: Set mc->max_cpus to GUEST_MAX_VCPUS in xen_arm_init(), Volodymyr Babchuk, 2023/11/10
- [PATCH v1 7/7] xen_arm: Add basic virtio-pci support, Volodymyr Babchuk, 2023/11/10
- [PATCH v1 1/7] xen-block: Do not write frontend nodes, Volodymyr Babchuk, 2023/11/10
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, David Woodhouse, 2023/11/11
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, Andrew Cooper, 2023/11/11
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, David Woodhouse, 2023/11/11
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, Andrew Cooper, 2023/11/11
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, David Woodhouse, 2023/11/11
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes,
Volodymyr Babchuk <=
- Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, David Woodhouse, 2023/11/14
Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes, Paul Durrant, 2023/11/12
[PATCH v1 2/7] xen-bus: Do not destroy frontend/backend directories, Volodymyr Babchuk, 2023/11/10
[PATCH v1 4/7] xen_pvdev: Do not assume Dom0 when creating a directrory, Volodymyr Babchuk, 2023/11/10
[PATCH v1 5/7] xen-bus: Set offline if backend's state is XenbusStateClosed, Volodymyr Babchuk, 2023/11/10