Re: [PATCH v5 24/31] machine: Use error handling when CPU type is checked

[Richard Henderson]

On 11/14/23 17:21, Richard Henderson wrote:
> On 11/14/23 15:56, Gavin Shan wrote:
> > QEMU will be terminated if the specified CPU type isn't supported
> > in machine_run_board_init(). The list of supported CPU type names
> > is tracked by mc->valid_cpu_types.
> >
> > The error handling can be used to propagate error messages, to be
> > consistent how the errors are handled for other situations in the
> > same function.
> >
> > No functional change intended.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Gavin Shan <gshan@redhat.com>
> > ---
> >   hw/core/machine.c | 14 ++++++++------
> >   1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 0c17398141..5b45dbbbd5 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -1394,6 +1394,7 @@ void machine_run_board_init(MachineState *machine, const char 
> > *mem_path, Error *
> >       MachineClass *machine_class = MACHINE_GET_CLASS(machine);
> >       ObjectClass *oc = object_class_by_name(machine->cpu_type);
> >       CPUClass *cc;
> > +    Error *local_err = NULL;
>
>
> There is no need for local_error; just use errp throughout.
>
> With that,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Alternately, is this because passing &error_fatal will abort on the first error_setg, 
without all the hints?

In which case you can move local_error into the inner block and add a comment 
to that effect.


r~