RE: [PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox

[address@hidden]

-----Original Message-----
From: Peter Maydell <peter.maydell@linaro.org>
Sent: Tuesday, November 14, 2023 6:58 PM
To: CS20 KFTing <KFTING@nuvoton.com>
Cc: Nabih Estefan <nabihestefan@google.com>; qemu-arm@nongnu.org; 
qemu-devel@nongnu.org; wuhaotsh@google.com; jasonwang@redhat.com; IS20 Avi 
Fishman <Avi.Fishman@nuvoton.com>; CS20 KWLiu <KWLIU@nuvoton.com>; IS20 Tomer 
Maimon <tomer.maimon@nuvoton.com>; IN20 Hila Miranda-Kuzi 
<Hila.Miranda-Kuzi@nuvoton.com>
Subject: Re: [PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox



On Tue, 14 Nov 2023 at 01:24, KFTING@nuvoton.com <KFTING@nuvoton.com> wrote:
>
>
>
> -----Original Message-----
> From: Nabih Estefan <nabihestefan@google.com>
> Sent: Saturday, October 28, 2023 1:55 AM
> To: peter.maydell@linaro.org
> Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing
> <KFTING@nuvoton.com>; wuhaotsh@google.com; jasonwang@redhat.com; IS20
> Avi Fishman <Avi.Fishman@nuvoton.com>; nabihestefan@google.com; CS20
> KWLiu <KWLIU@nuvoton.com>; IS20 Tomer Maimon
> <tomer.maimon@nuvoton.com>; IN20 Hila Miranda-Kuzi
> <Hila.Miranda-Kuzi@nuvoton.com>
> Subject: [PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox
>
> CAUTION - External Email: Do not click links or open attachments unless you 
> acknowledge the sender and content.
>
>
> From: Hao Wu <wuhaotsh@google.com>
>
> This patches adds a qtest for NPCM7XX PCI Mailbox module.
> It sends read and write requests to the module, and verifies that the module 
> contains the correct data after the requests.
>
> Change-Id: Id7a4b3cbea564383b94d507552dfd16f6b5127d1
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
> ---


> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>

Hi; can you clarify what you mean with this Signed-off-by: tag?
Generally we use those where either you're the author of the code or else when 
you're taking somebody else's patch and including it in work you are sending to 
the list, and it doesn't seem like either of those are the case here.


thanks
-- PMM

Hi:

Thank you for your comments. In the email thread " [PATCH v4 00/11] 
Implementation of NPI Mailbox and GMAC Networking Module",
it says " Hi; I'm afraid this is going to miss the 8.2 release, because it is 
still missing any review from Google or Nuvoton people."

Is it okay to post "Acked by:" or "Reviewed by:" by someone from Nuvoton?

Thank you.

Regards,
Tyrone
________________________________
________________________________
 The privileged confidential information contained in this email is intended 
for use only by the addressees as indicated by the original sender of this 
email. If you are not the addressee indicated in this email or are not 
responsible for delivery of the email to such a person, please kindly reply to 
the sender indicating this fact and delete all copies of it from your computer 
and network server immediately. Your cooperation is highly appreciated. It is 
advised that any unauthorized use of confidential information of Nuvoton is 
strictly prohibited; and any information in this email irrelevant to the 
official business of Nuvoton shall be deemed as neither given nor endorsed by 
Nuvoton.