RE: [PATCH v6 08/21] vfio/pci: Introduce a vfio pci hot reset interface

[Duan, Zhenzhong]

>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Sent: Tuesday, November 14, 2023 9:52 PM
>Subject: Re: [PATCH v6 08/21] vfio/pci: Introduce a vfio pci hot reset 
>interface
>
>On 11/14/23 11:09, Zhenzhong Duan wrote:
>> Legacy vfio pci and iommufd cdev have different process to hot reset
>> vfio device, expand current code to abstract out pci_hot_reset callback
>> for legacy vfio, this same interface will also be used by iommufd
>> cdev vfio device.
>>
>> Rename vfio_pci_hot_reset to vfio_legacy_pci_hot_reset and move it
>> into container.c.
>>
>> vfio_pci_[pre/post]_reset and vfio_pci_host_match are exported so
>> they could be called in legacy and iommufd pci_hot_reset callback.
>
>vfio_pci_host_match() is never used outside ot the legacy reset cb.
>Do you have future plans ?

No future plans, I'm just following a rule to keep pci specific functions
in pci.c whenever possible. Maybe another rule is to make functions
static whenever possible. I'm fine with both😊

Thanks
Zhenzhong