Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object

[Cédric Le Goater]

On 11/15/23 05:06, Duan, Zhenzhong wrote:
> > -----Original Message-----
> > From: Cédric Le Goater <clg@redhat.com>
> > Sent: Tuesday, November 14, 2023 9:29 PM
> > Subject: Re: [PATCH v6 01/21] backends/iommufd: Introduce the iommufd object
> >
> > On 11/14/23 11:09, Zhenzhong Duan wrote:
> > > From: Eric Auger <eric.auger@redhat.com>
> > >
> > > Introduce an iommufd object which allows the interaction
> > > with the host /dev/iommu device.
> > >
> > > The /dev/iommu can have been already pre-opened outside of qemu,
> > > in which case the fd can be passed directly along with the
> > > iommufd object:
> > >
> > > This allows the iommufd object to be shared accross several
> > > subsystems (VFIO, VDPA, ...). For example, libvirt would open
> > > the /dev/iommu once.
> > >
> > > If no fd is passed along with the iommufd object, the /dev/iommu
> > > is opened by the qemu code.
> > >
> > > Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> > > Signed-off-by: Eric Auger <eric.auger@redhat.com>
> > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> >
> > I simplified the object declaration in include/sysemu/iommufd.h and
> > formatted /dev/iommu in qemu-options.hx. No need to resend.
>
> Good catch, thanks! Maybe further simplified with below? This is minor.
>
> OBJECT_DECLARE_TYPE(IOMMUFDBackend, IOMMUFDBackendClass, IOMMUFD_BACKEND)

Indeed. Done.



Thanks,

C.