Re: [PATCH] monitor: flush messages on abort

[Markus Armbruster]

Steven Sistare <steven.sistare@oracle.com> writes:

> On 11/15/2023 3:41 AM, Markus Armbruster wrote:
>> Daniel P. Berrangé <berrange@redhat.com> writes:
>> 
>>> On Fri, Nov 03, 2023 at 03:51:00PM -0400, Steven Sistare wrote:
>>>> On 11/3/2023 1:33 PM, Daniel P. Berrangé wrote:
>>>>> On Fri, Nov 03, 2023 at 09:01:29AM -0700, Steve Sistare wrote:
>>>>>> Buffered monitor output is lost when abort() is called.  The pattern
>>>>>> error_report() followed by abort() occurs about 60 times, so valuable
>>>>>> information is being lost when the abort is called in the context of a
>>>>>> monitor command.
>>>>>
>>>>> I'm curious, was there a particular abort() scenario that you hit ?
>>>>
>>>> Yes, while tweaking the suspended state, and forgetting to add transitions:
>>>>
>>>>         error_report("invalid runstate transition: '%s' -> '%s'",
>>>>         abort();
>>>>
>>>> But I have previously hit this for other errors.
>> 
>> Can you provide a reproducer?
>
> I sometimes hit this when developing new code.  I do not have a reproducer 
> for upstream
> branches. The patch is aimed at helping developers, not users.

I'm asking because I can't see how the error message could be lost.  A
reproducer would let me find out.  "Apply this set of broken patches,
then do that" would serve.

[...]