Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path

[Manos Pitsidianakis]

On Thu, 16 Nov 2023 10:42, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> On 16/11/23 08:33, Manos Pitsidianakis wrote:
> > On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé <philmd@linaro.org> 
> > wrote:
> > > > ---
> > > >
> > > > Notes:
> > > >      Requires patch 
> > > > <20231109162034.2108018-1-manos.pitsidianakis@linaro.org>
> > >
> > > This is the 'Based-on: ' tag I guess.
> >
> > There is
> >
> >   prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
>
> $ git show 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
> fatal: bad object 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
>
> In which tree can we find this commit? Better to use the msg-id,
> so tools cat fetch prerequisite.
>
> I guess the 'patches' tool understand 'Based-on'. Or was it 'patchew'?

It's not a commit SHA, that's why. It's a sha produced by git-patch-id 
--stable. It hashes the diffs of the plain-text patch.

https://git-scm.com/docs/git-patch-id

Yes, whatever works with current tools is best!

Manos