qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qom/object: Limit type names to alphanumerical and some few


From: Peter Maydell
Subject: Re: [PATCH] qom/object: Limit type names to alphanumerical and some few special characters
Date: Thu, 16 Nov 2023 11:37:38 +0000

On Thu, 16 Nov 2023 at 11:17, Thomas Huth <thuth@redhat.com> wrote:
> 2) #define TYPE_RAM_DISCARD_MANAGER "qemu:ram-discard-manager"
>     in include/exec/memory.h ... I believe it should be OK to
>     simply rename it, since it's about an interface type...
>     Or do we use these interface names in migration streams, too?

No, QOM type names are separate from migration stream section
names (unless somebody has explicitly set the migration stream
section name to be the QOM type name using ".name = TYPE_WHATEVER"
in a VMStateDescription struct, which in this case they haven't;
and I'm not sure that even the VMStateDescription names end up
on the wire).

It should be safe to change the type name string here.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]