Re: [PATCH for-8.2] Revert "ui/console: allow to override the default VC"

[David Woodhouse]

On 16 November 2023 13:22:28 GMT-05:00, Peter Maydell 
<peter.maydell@linaro.org> wrote:
>This reverts commit 1bec1cc0da497e55c16e2a7b50f94cdb2a02197f.  This
>commit changed the behaviour of the "-display none" option, so that
>it now creates a QEMU monitor on the terminal.  "-display none"
>should not be tangled up with whether we create a monitor or a serial
>terminal; it should purely and only disable the graphical window.
>Changing its behaviour like this breaks command lines which, for
>example, use semihosting for their output and don't want a graphical
>window, as they now get a monitor they never asked for.
>
>It also breaks the command line we document for Xen in
>docs/system/i386/xen.html:
>
> $ ./qemu-system-x86_64 --accel kvm,xen-version=0x40011,kernel-irqchip=split \
>    -display none -chardev stdio,mux=on,id=char0,signal=off -mon char0 \
>    -device xen-console,chardev=char0  -drive file=${GUEST_IMAGE},if=xen
>
>qemu-system-x86_64: cannot use stdio by multiple character devices
>qemu-system-x86_64: could not connect serial device to character backend 
>'stdio'
>
>Revert the commit to restore the previous handling of "-display
>none".
>
>Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1974
>Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: <dwmw@amazon.co.uk>