[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/7] target/i386/cpu: Improve error message for property "vendor"
|
From: |
Markus Armbruster |
|
Subject: |
[PULL 7/7] target/i386/cpu: Improve error message for property "vendor" |
|
Date: |
Fri, 17 Nov 2023 10:53:34 +0100 |
Improve
$ qemu-system-x86_64 -device max-x86_64-cpu,vendor=me
qemu-system-x86_64: -device max-x86_64-cpu,vendor=me: Property '.vendor'
doesn't take value 'me'
to
qemu-system-x86_64: -device max-x86_64-cpu,vendor=0123456789abc: value of
property 'vendor' must consist of exactly 12 characters
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231031111059.3407803-8-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[Typo corrected]
---
target/i386/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 358d9c0a65..cd16cb893d 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5192,7 +5192,8 @@ static void x86_cpuid_set_vendor(Object *obj, const char
*value,
int i;
if (strlen(value) != CPUID_VENDOR_SZ) {
- error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value);
+ error_setg(errp, "value of property 'vendor' must consist of"
+ " exactly " stringify(CPUID_VENDOR_SZ) " characters");
return;
}
--
2.41.0
- [PULL 0/7] Error reporting patches for 2023-11-17, Markus Armbruster, 2023/11/17
- [PULL 6/7] balloon: Fix a misleading error message, Markus Armbruster, 2023/11/17
- [PULL 5/7] net: Fix a misleading error message, Markus Armbruster, 2023/11/17
- [PULL 2/7] hmp: Improve sync-profile error message, Markus Armbruster, 2023/11/17
- [PULL 1/7] spapr/pci: Correct "does not support hotplugging error messages, Markus Armbruster, 2023/11/17
- [PULL 3/7] qga: Improve guest-exec-status error message, Markus Armbruster, 2023/11/17
- [PULL 4/7] ui/qmp-cmds: Improve two error messages, Markus Armbruster, 2023/11/17
- [PULL 7/7] target/i386/cpu: Improve error message for property "vendor",
Markus Armbruster <=
- Re: [PULL 0/7] Error reporting patches for 2023-11-17, Stefan Hajnoczi, 2023/11/20