[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] migration: free 'saddr' since be no longer used
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v2] migration: free 'saddr' since be no longer used |
|
Date: |
Fri, 17 Nov 2023 08:56:13 -0500 |
On Fri, Nov 17, 2023 at 10:51:18AM +0800, Zongmin Zhou wrote:
> > As Peter said, putting a comment why we don't use
> > qapi_free_SocketAddress() will be a good idea.
>
> I have put some comments on patch v2 to explain
Normally we use "comment" to represent direct comment in the code. You
explained it in the "commit message". :)
That explanation is good enough to me, you can add a summary comment in the
code too. Something like:
/* Don't free the objects inside; their ownership moved to "addr" */
--
Peter Xu
- [PATCH] migration: free 'saddr' since be no longer used, Zongmin Zhou, 2023/11/14
- Re: [PATCH] migration: free 'saddr' since be no longer used, Daniel P . Berrangé, 2023/11/15
- Re: [PATCH] migration: free 'saddr' since be no longer used, Peter Xu, 2023/11/15
- [PATCH v2] migration: free 'saddr' since be no longer used, Zongmin Zhou, 2023/11/16
- Re: [PATCH v2] migration: free 'saddr' since be no longer used, Juan Quintela, 2023/11/16
- Re: [PATCH v2] migration: free 'saddr' since be no longer used, Zongmin Zhou, 2023/11/16
- Re: [PATCH v2] migration: free 'saddr' since be no longer used,
Peter Xu <=
- [PATCH v3] migration: free 'saddr' since be no longer used, Zongmin Zhou, 2023/11/19
- Re: [PATCH v3] migration: free 'saddr' since be no longer used, Daniel P . Berrangé, 2023/11/20
- Re: [PATCH v3] migration: free 'saddr' since be no longer used, Peter Xu, 2023/11/20
- Re: [PATCH v3] migration: free 'saddr' since be no longer used, Zongmin Zhou, 2023/11/28
- Re: [PATCH v3] migration: free 'saddr' since be no longer used, Peter Xu, 2023/11/29
- Re: [PATCH v3] migration: free 'saddr' since be no longer used, Het Gala, 2023/11/30