[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/8] target/arm: Fix SME FMOPA (16-bit), BFMOPA
|
From: |
Peter Maydell |
|
Subject: |
[PULL 3/8] target/arm: Fix SME FMOPA (16-bit), BFMOPA |
|
Date: |
Tue, 21 Nov 2023 10:24:36 +0000 |
From: Richard Henderson <richard.henderson@linaro.org>
Perform the loop increment unconditionally, not nested
within the predication.
Cc: qemu-stable@nongnu.org
Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1985
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20231117193135.1180657-1-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/tcg/sme_helper.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
index 296826ffe6a..1ee2690ceb5 100644
--- a/target/arm/tcg/sme_helper.c
+++ b/target/arm/tcg/sme_helper.c
@@ -1037,10 +1037,9 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void
*vzm, void *vpn,
m = f16mop_adj_pair(m, pcol, 0);
*a = f16_dotadd(*a, n, m, &fpst_std, &fpst_odd);
-
- col += 4;
- pcol >>= 4;
}
+ col += 4;
+ pcol >>= 4;
} while (col & 15);
}
row += 4;
@@ -1073,10 +1072,9 @@ void HELPER(sme_bfmopa)(void *vza, void *vzn, void *vzm,
void *vpn,
m = f16mop_adj_pair(m, pcol, 0);
*a = bfdotadd(*a, n, m);
-
- col += 4;
- pcol >>= 4;
}
+ col += 4;
+ pcol >>= 4;
} while (col & 15);
}
row += 4;
--
2.34.1
- [PULL 0/8] target-arm queue, Peter Maydell, 2023/11/21
- [PULL 1/8] target/arm: enable FEAT_RNG on Neoverse-N2, Peter Maydell, 2023/11/21
- [PULL 2/8] hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ, Peter Maydell, 2023/11/21
- [PULL 3/8] target/arm: Fix SME FMOPA (16-bit), BFMOPA,
Peter Maydell <=
- [PULL 5/8] hw/arm/stm32f405: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 6/8] hw/arm/stm32f205: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 4/8] hw/core/machine: Constify MachineClass::valid_cpu_types[], Peter Maydell, 2023/11/21
- [PULL 7/8] hw/arm/stm32f100: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 8/8] hw/arm/fsl-imx: Do not ignore Error argument, Peter Maydell, 2023/11/21
- Re: [PULL 0/8] target-arm queue, Stefan Hajnoczi, 2023/11/21