[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] hw/arm/fsl-imx: Do not ignore Error argument
From: |
Peter Maydell |
Subject: |
[PULL 8/8] hw/arm/fsl-imx: Do not ignore Error argument |
Date: |
Tue, 21 Nov 2023 10:24:41 +0000 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Both i.MX25 and i.MX6 SoC models ignore the Error argument when
setting the PHY number. Pick &error_abort which is the error
used by the i.MX7 SoC (see commit 1f7197deb0 "ability to change
the FEC PHY on i.MX7 processor").
Fixes: 74c1330582 ("ability to change the FEC PHY on i.MX25 processor")
Fixes: a9c167a3c4 ("ability to change the FEC PHY on i.MX6 processor")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20231120115116.76858-1-philmd@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/fsl-imx25.c | 3 ++-
hw/arm/fsl-imx6.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c
index 24c43745903..9aabbf7f587 100644
--- a/hw/arm/fsl-imx25.c
+++ b/hw/arm/fsl-imx25.c
@@ -169,7 +169,8 @@ static void fsl_imx25_realize(DeviceState *dev, Error
**errp)
epit_table[i].irq));
}
- object_property_set_uint(OBJECT(&s->fec), "phy-num", s->phy_num, &err);
+ object_property_set_uint(OBJECT(&s->fec), "phy-num", s->phy_num,
+ &error_abort);
qdev_set_nic_properties(DEVICE(&s->fec), &nd_table[0]);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->fec), errp)) {
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index 4fa7f0b95ed..7dc42cbfe64 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -379,7 +379,8 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp)
spi_table[i].irq));
}
- object_property_set_uint(OBJECT(&s->eth), "phy-num", s->phy_num, &err);
+ object_property_set_uint(OBJECT(&s->eth), "phy-num", s->phy_num,
+ &error_abort);
qdev_set_nic_properties(DEVICE(&s->eth), &nd_table[0]);
if (!sysbus_realize(SYS_BUS_DEVICE(&s->eth), errp)) {
return;
--
2.34.1
- [PULL 0/8] target-arm queue, Peter Maydell, 2023/11/21
- [PULL 1/8] target/arm: enable FEAT_RNG on Neoverse-N2, Peter Maydell, 2023/11/21
- [PULL 2/8] hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ, Peter Maydell, 2023/11/21
- [PULL 3/8] target/arm: Fix SME FMOPA (16-bit), BFMOPA, Peter Maydell, 2023/11/21
- [PULL 5/8] hw/arm/stm32f405: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 6/8] hw/arm/stm32f205: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 4/8] hw/core/machine: Constify MachineClass::valid_cpu_types[], Peter Maydell, 2023/11/21
- [PULL 7/8] hw/arm/stm32f100: Report error when incorrect CPU is used, Peter Maydell, 2023/11/21
- [PULL 8/8] hw/arm/fsl-imx: Do not ignore Error argument,
Peter Maydell <=
- Re: [PULL 0/8] target-arm queue, Stefan Hajnoczi, 2023/11/21