[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/5] vl: add missing display_remote++
|
From: |
marcandre . lureau |
|
Subject: |
[PULL 4/5] vl: add missing display_remote++ |
|
Date: |
Tue, 21 Nov 2023 14:40:19 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
We should also consider -display vnc= as setting up a remote display,
and not attempt to add another default one.
The display_remote++ in qemu_setup_display() isn't necessary at this
point, but is there for completeness and further usages of the variable.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1988
Fixes: commit 484629fc81 ("vl: simplify display_remote logic ")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
system/vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/system/vl.c b/system/vl.c
index 14bf0cf0bf..da2654aa77 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -1110,6 +1110,7 @@ static void parse_display(const char *p)
*/
if (*opts == '=') {
vnc_parse(opts + 1);
+ display_remote++;
} else {
error_report("VNC requires a display argument vnc=<display>");
exit(1);
@@ -1359,6 +1360,7 @@ static void qemu_setup_display(void)
dpy.type = DISPLAY_TYPE_NONE;
#if defined(CONFIG_VNC)
vnc_parse("localhost:0,to=99,id=default");
+ display_remote++;
#endif
}
}
--
2.42.0
- [PULL 2/5] ui/gtk-egl: Check EGLSurface before doing scanout, (continued)
- [PULL 2/5] ui/gtk-egl: Check EGLSurface before doing scanout, marcandre . lureau, 2023/11/07
- [PULL 5/5] ui: Replacing pointer in function, marcandre . lureau, 2023/11/07
- Re: [PULL 0/5] Ui patches, Stefan Hajnoczi, 2023/11/07
- Re: [PULL 0/5] Ui patches, Michael Tokarev, 2023/11/07
- [PULL 0/5] Ui patches, marcandre . lureau, 2023/11/21
- [PULL 1/5] vl: revert behaviour for -display none, marcandre . lureau, 2023/11/21
- [PULL 2/5] ui: use "vc" chardev for dbus, gtk & spice-app, marcandre . lureau, 2023/11/21
- [PULL 3/5] ui/console: fix default VC when there are no display, marcandre . lureau, 2023/11/21
- [PULL 4/5] vl: add missing display_remote++,
marcandre . lureau <=
- [PULL 5/5] ui/pixman-minimal.h: fix empty allocation, marcandre . lureau, 2023/11/21
- Re: [PULL 0/5] Ui patches, Stefan Hajnoczi, 2023/11/21