Re: [PATCH for-8.2] ui/pixman-minimal.h: fix empty allocation

[Manos Pitsidianakis]

On Thu, 23 Nov 2023 12:15, Michael Tokarev <mjt@tls.msk.ru> wrote:
> 21.11.2023 12:38, Manos Pitsidianakis :
> > In the minimal pixman API stub that is used when the real pixman
> > dependency is missing a NULL dereference happens when
> > virtio-gpu-rutabaga allocates a pixman image with bits = NULL and
> > rowstride_bytes = zero. A buffer of rowstride_bytes * height is
> > allocated which is NULL. However, in that scenario pixman calculates a
> > new stride value based on given width, height and format size.
>
> So, does rutabaga depend on pixman (as mentioned on irc), or can the
> minimal in-qemu version (with this fix) be used?

I think it probably does not depend on missing functionality; it seems 
to only be passing the allocated data to the external library and not 
pixman types. I'd have to check on amd64 where I previously ran rutabaga 
successfuly in qemu; now I'm trying to get it to work on aarch64 and I'm 
trying to figure out some control message errors from the guest kernel 
driver. When/if I try it again on amd64 and it's not working, I will 
either report or send a patch.