[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/10] system: Use &error_abort in memory_region_init_ram_[device_
|
From: |
Paolo Bonzini |
|
Subject: |
[PULL 08/10] system: Use &error_abort in memory_region_init_ram_[device_]ptr() |
|
Date: |
Fri, 24 Nov 2023 16:24:06 +0100 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
If an unexpected error condition happens, we have to abort
(&fatal_error is meant for expected errors).
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231120133112.82447-1-philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
system/memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/system/memory.c b/system/memory.c
index 304fa843ea1..4d9cb0a7fff 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -1692,7 +1692,7 @@ void memory_region_init_ram_ptr(MemoryRegion *mr,
/* qemu_ram_alloc_from_ptr cannot fail with ptr != NULL. */
assert(ptr != NULL);
- mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_fatal);
+ mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_abort);
}
void memory_region_init_ram_device_ptr(MemoryRegion *mr,
@@ -1711,7 +1711,7 @@ void memory_region_init_ram_device_ptr(MemoryRegion *mr,
/* qemu_ram_alloc_from_ptr cannot fail with ptr != NULL. */
assert(ptr != NULL);
- mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_fatal);
+ mr->ram_block = qemu_ram_alloc_from_ptr(size, ptr, mr, &error_abort);
}
void memory_region_init_alias(MemoryRegion *mr,
--
2.43.0
- [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2, Paolo Bonzini, 2023/11/24
- [PULL 01/10] coverity: physmem: use simple assertions instead of modelling, Paolo Bonzini, 2023/11/24
- [PULL 02/10] tests: respect --enable/--disable-download for Avocado, Paolo Bonzini, 2023/11/24
- [PULL 03/10] docs: document what configure does with virtual environments, Paolo Bonzini, 2023/11/24
- [PULL 04/10] buildsys: Bump known good meson version to v1.2.3, Paolo Bonzini, 2023/11/24
- [PULL 05/10] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma), Paolo Bonzini, 2023/11/24
- [PULL 06/10] audio: Free consumed default audio devices, Paolo Bonzini, 2023/11/24
- [PULL 08/10] system: Use &error_abort in memory_region_init_ram_[device_]ptr(),
Paolo Bonzini <=
- [PULL 07/10] disas/cris: Pass buffer size to format_dec() to avoid overflow warning, Paolo Bonzini, 2023/11/24
- [PULL 09/10] configure: Make only once with pseudo-"in source tree" builds, Paolo Bonzini, 2023/11/24
- [PULL 10/10] scripts: adjust url to Coverity tools, Paolo Bonzini, 2023/11/24
- Re: [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2, Stefan Hajnoczi, 2023/11/28