Re: [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid

[Eric Blake]

On Fri, Nov 24, 2023 at 11:56:54AM +0000, Fam wrote:
> From: Fam Zheng <fam@euphon.net>
> 
> If the text description file is larger than DESC_SIZE, we force the last
> byte in the buffer to be 0 and write it out.
> 
> This results in a corruption.
> 
> Try to allocate a big buffer in this case.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923
> 
> Signed-off-by: Fam Zheng <fam@euphon.net>
> ---
>  block/vmdk.c               | 28 ++++++++++++++++++++--------
>  tests/qemu-iotests/059     |  2 ++
>  tests/qemu-iotests/059.out |  4 ++++
>  3 files changed, 26 insertions(+), 8 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Are we trying to get this into 8.2, since it is a data corruption?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org