[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] virtio-scsi: don't lock AioContext around virtio_queue_a
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 2/4] virtio-scsi: don't lock AioContext around virtio_queue_aio_attach_host_notifier() |
|
Date: |
Mon, 27 Nov 2023 09:21:08 -0600 |
|
User-agent: |
NeoMutt/20231103 |
On Thu, Nov 23, 2023 at 02:49:29PM -0500, Stefan Hajnoczi wrote:
> virtio_queue_aio_attach_host_notifier() does not require the AioContext
> lock. Stop taking the lock and remember add an explicit smp_wmb()
s/remember// ?
> because we were relying on the implicit barrier in the AioContext lock
> before.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/scsi/virtio-scsi-dataplane.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH 0/4] scsi: eliminate AioContext lock, Stefan Hajnoczi, 2023/11/23
- [PATCH 1/4] scsi: only access SCSIDevice->requests from one thread, Stefan Hajnoczi, 2023/11/23
- [PATCH 2/4] virtio-scsi: don't lock AioContext around virtio_queue_aio_attach_host_notifier(), Stefan Hajnoczi, 2023/11/23
- Re: [PATCH 2/4] virtio-scsi: don't lock AioContext around virtio_queue_aio_attach_host_notifier(),
Eric Blake <=
- [PATCH 3/4] scsi: don't lock AioContext in I/O code path, Stefan Hajnoczi, 2023/11/23
- [PATCH 4/4] dma-helpers: don't lock AioContext in dma_blk_cb(), Stefan Hajnoczi, 2023/11/23
- Re: [PATCH 0/4] scsi: eliminate AioContext lock, Stefan Hajnoczi, 2023/11/23