[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 03/10] vdpa: merge _begin_batch into _batch_begin_once
|
From: |
Eugenio Pérez |
|
Subject: |
[RFC PATCH v2 03/10] vdpa: merge _begin_batch into _batch_begin_once |
|
Date: |
Tue, 28 Nov 2023 11:42:56 +0100 |
There was only one call. This way we can make the begin and end of the
batch symmetrical.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index bf9771870a..a533fc5bc7 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -143,7 +143,7 @@ int vhost_vdpa_dma_unmap(VhostVDPAShared *s, uint32_t asid,
hwaddr iova,
return ret;
}
-static void vhost_vdpa_listener_begin_batch(VhostVDPAShared *s)
+static void vhost_vdpa_iotlb_batch_begin_once(VhostVDPAShared *s)
{
int fd = s->device_fd;
struct vhost_msg_v2 msg = {
@@ -151,21 +151,16 @@ static void
vhost_vdpa_listener_begin_batch(VhostVDPAShared *s)
.iotlb.type = VHOST_IOTLB_BATCH_BEGIN,
};
- trace_vhost_vdpa_listener_begin_batch(s, fd, msg.type, msg.iotlb.type);
- if (write(fd, &msg, sizeof(msg)) != sizeof(msg)) {
- error_report("failed to write, fd=%d, errno=%d (%s)",
- fd, errno, strerror(errno));
- }
-}
-
-static void vhost_vdpa_iotlb_batch_begin_once(VhostVDPAShared *s)
-{
if (!(s->backend_cap & (0x1ULL << VHOST_BACKEND_F_IOTLB_BATCH)) ||
s->iotlb_batch_begin_sent) {
return;
}
- vhost_vdpa_listener_begin_batch(s);
+ trace_vhost_vdpa_listener_begin_batch(s, fd, msg.type, msg.iotlb.type);
+ if (write(fd, &msg, sizeof(msg)) != sizeof(msg)) {
+ error_report("failed to write, fd=%d, errno=%d (%s)",
+ fd, errno, strerror(errno));
+ }
s->iotlb_batch_begin_sent = true;
}
--
2.39.3
- [RFC PATCH v2 00/10] Map memory at destination .load_setup in vDPA-net migration, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 01/10] vdpa: do not set virtio status bits if unneeded, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 02/10] vdpa: make batch_begin_once early return, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 04/10] vdpa: extract out _dma_end_batch from _listener_commit, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 03/10] vdpa: merge _begin_batch into _batch_begin_once,
Eugenio Pérez <=
- [RFC PATCH v2 05/10] vdpa: factor out stop path of vhost_vdpa_dev_start, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 06/10] vdpa: check for iova tree initialized at net_client_start, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 08/10] vdpa: add vhost_vdpa_load_setup, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 07/10] vdpa: set backend capabilities at vhost_vdpa_init, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 10/10] virtio_net: register incremental migration handlers, Eugenio Pérez, 2023/11/28
- [RFC PATCH v2 09/10] vdpa: add vhost_vdpa_net_load_setup NetClient callback, Eugenio Pérez, 2023/11/28