Re: QEMU Summit Minutes 2023

[Stefan Hajnoczi]

On Wed, 29 Nov 2023 at 09:22, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 28/11/23 19:06, Daniel P. Berrangé wrote:
> > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote:
>
> > Anyway, when a maintainer wants to merge a tree, I would expect to
> > have a MR opened against 'master' in qemu-project/qemu.  The CI
> > ought to then run and if it is all green, then someone would approve
> > it to merge to master.
> >
> >> It seems to me that we should also have a group of people approving
> >> the MR.
> >
> > Yes, while we could have one designated gate keeper approving all
> > MRs, that would defeat some of the benefit of MRs. So likely would
> > be good to have a pool, and also setup the config so that the owner
> > of an MR is not allow to approve their own MR, to guarantee there
> > is always a 2nd pair of eyes as sanity check.
>
> Are all our tests already on GitLab? Last time I remember Peter still
> had manual tests.

Hi Philippe,
QEMU no longer depends on those manual tests even if they still exist.
I did not run any manual tests during the 8.2 release cycle.

I want to highlight that the CI is not yet reliable. It fails due to
intermittent issues more often than it passes. Most of the issues are
related to unreliable test cases. Some of the issues are related to
temporary infrastructure outages where the tests fail when
initializing the environment (e.g. failure to download dependencies).

I am willing to review the CI failure history for the past two weeks
and submit patches to disable unreliable tests. The test owners can
investigate and fix those tests if they want to re-enable them.

Stefan