qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/70] RAMBlock/guest_memfd: Enable KVM_GUEST_MEMFD_ALLOW_


From: Xiaoyao Li
Subject: Re: [PATCH v3 03/70] RAMBlock/guest_memfd: Enable KVM_GUEST_MEMFD_ALLOW_HUGEPAGE
Date: Thu, 30 Nov 2023 16:00:08 +0800
User-agent: Mozilla Thunderbird

On 11/20/2023 5:26 PM, David Hildenbrand wrote:

... did you shamelessly copy that from hw/virtio/virtio-mem.c ? ;)

Get caught.

This should be factored out into a common helper.

Sure, will do it in next version.

Factor it out in a separate patch. Then, this patch is get small that you can just squash it into #2.

A silly question. What file should the factored function be put in?

And my comment regarding "flags = 0" to patch #2 does no longer apply :)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]