Re: [PATCH 1/9] sparc/grlib: split out the headers for each peripherals

[Philippe Mathieu-Daudé]

On 5/1/24 11:24, Clément Chigot wrote:
> ... and move them in their right hardware directory.
>
> Co-developed-by: Frederic Konrad <konrad.frederic@yahoo.fr>
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
>   hw/char/grlib_apbuart.c                       |  4 +--
>   hw/intc/grlib_irqmp.c                         |  4 +--
>   hw/sparc/leon3.c                              |  6 ++--
>   hw/timer/grlib_gptimer.c                      |  4 +--
>   include/hw/char/grlib_uart.h                  | 30 +++++++++++++++++++
>   .../hw/{sparc/grlib.h => intc/grlib_irqmp.h}  | 14 +++------
>   include/hw/timer/grlib_gptimer.h              | 30 +++++++++++++++++++
>   7 files changed, 74 insertions(+), 18 deletions(-)
>   create mode 100644 include/hw/char/grlib_uart.h
>   rename include/hw/{sparc/grlib.h => intc/grlib_irqmp.h} (86%)
>   create mode 100644 include/hw/timer/grlib_gptimer.h

This still matches the MAINTAINERS patterns, good.

> diff --git a/include/hw/char/grlib_uart.h b/include/hw/char/grlib_uart.h
> new file mode 100644
> index 0000000000..b67da6c62a
> --- /dev/null
> +++ b/include/hw/char/grlib_uart.h
> @@ -0,0 +1,30 @@
> +/*
> + * QEMU GRLIB UART
> + *
> + * Copyright (c) 2024 AdaCore
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to 
> deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.

When adding license, SPDX tag is prefered (although not enforced)
because it eases tools parsing.

> + */
> +
> +#ifndef GRLIB_UART_H
> +#define GRLIB_UART_H
> +
> +#define TYPE_GRLIB_APB_UART "grlib-apbuart"
> +
> +#endif

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>