Re: [PATCH 2/2] hw/block: Deprecate the TC58128 block device

[Cédric Le Goater]

On 1/8/24 18:15, Samuel Tardieu wrote:
> The 16MiB flash device is only used by the deprecated shix machine.
> Its code it old and unmaintained, and has never been adapted to the
> QOM architecture. It still contains debug statements and uses global
> variables. It is time to deprecate it.
>
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   docs/about/deprecated.rst | 2 +-
>   hw/block/tc58128.c        | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index e6a12c9077..15e39f8bbb 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -273,7 +273,7 @@ The Nios II architecture is orphan.
>   ''''''''''''''''''''
>   
>   The machine is no longer in existence and has been long unmaintained
> -in QEMU.
> +in QEMU. This also holds for the TC51828 16MiB flash that it uses.
>   
>   Backend options
>   ---------------
> diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c
> index d350126b27..354c13ccf0 100644
> --- a/hw/block/tc58128.c
> +++ b/hw/block/tc58128.c
> @@ -202,6 +202,7 @@ static sh7750_io_device tc58128 = {
>   
>   int tc58128_init(struct SH7750State *s, const char *zone1, const char *zone2)
>   {
> +    warn_report_once("The TC58128 flash device is deprecated - use a newer 
> component");
>       init_dev(&tc58128_devs[0], zone1);
>       init_dev(&tc58128_devs[1], zone2);
>       return sh7750_register_io_device(s, &tc58128);