Re: [PATCH v3 11/46] hw/loongarch: use pci_init_nic_devices()

[gaosong]

在 2024/1/9 上午4:26, David Woodhouse 写道:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   hw/loongarch/virt.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks.
Song Gao
> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> index 4b7dc67a2d..c48804ac38 100644
> --- a/hw/loongarch/virt.c
> +++ b/hw/loongarch/virt.c
> @@ -504,9 +504,7 @@ static void loongarch_devices_init(DeviceState *pch_pic, 
> LoongArchMachineState *
>       fdt_add_uart_node(lams);
>   
>       /* Network init */
> -    for (i = 0; i < nb_nics; i++) {
> -        pci_nic_init_nofail(&nd_table[i], pci_bus, mc->default_nic, NULL);
> -    }
> +    pci_init_nic_devices(pci_bus, mc->default_nic);
>   
>       /*
>        * There are some invalid guest memory access.