RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

[Wentao Jia]

Hi, Jason 

The two features was defined before version 8.2, we can found them in qemu 8.2

VIRTIO_F_NOTIFICATION_DATA
https://github.com/qemu/qemu/commit/d0bf492f3877d4187d2f7d0c0abb3a2bf3104392
VIRTIO_F_IN_ORDER
https://github.com/qemu/qemu/commit/e4082063e47e9731dbeb1c26174c17f6038f577f

thank you

Wentao

-----Original Message-----
From: Jason Wang <jasowang@redhat.com> 
Sent: Tuesday, January 16, 2024 10:20 AM
To: Wentao Jia <wentao.jia@nephogine.com>
Cc: qemu-devel@nongnu.org; mst@redhat.com; Rick Zhong 
<zhaoyong.zhong@nephogine.com>
Subject: Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
VIRTIO_F_NOTIFICATION_DATA feature

On Tue, Jan 16, 2024 at 9:57 AM Wentao Jia <wentao.jia@nephogine.com> wrote:
>
> Hi, Jason
>
> I just add two features in vhost user feature bits, The patch was 
> tested in my environment I do not know what the compatibility mean

For example, if you don't do that,

Migrating from 9.0 to 8.2 will break as 8.2 doesn't have those new features at 
all.

Please refer hw_compat_8_2.

Thanks

>
> Wentao
>
> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Monday, January 15, 2024 8:18 AM
> To: Wentao Jia <wentao.jia@nephogine.com>
> Cc: qemu-devel@nongnu.org; mst@redhat.com; Rick Zhong 
> <zhaoyong.zhong@nephogine.com>
> Subject: Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
> VIRTIO_F_NOTIFICATION_DATA feature
>
> On Fri, Jan 12, 2024 at 4:18 PM Wentao Jia <wentao.jia@nephogine.com> wrote:
> >
> > Hi, Michael and Jason
> >
> > Do you have any other comments?
> > Is there a schedule for merge the patch into the community?
> > Thank you
>
> I think as discussed, we need to add compatibility support for those features.
>
> Thanks
>
> >
> > Wentao
> >
> > -----Original Message-----
> > From: Wentao Jia
> > Sent: Tuesday, January 2, 2024 1:57 PM
> > To: qemu-devel@nongnu.org
> > Cc: 'mst@redhat.com' <mst@redhat.com>; Rick Zhong 
> > <zhaoyong.zhong@nephogine.com>; 'Jason Wang' <jasowang@redhat.com>
> > Subject: RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
> > VIRTIO_F_NOTIFICATION_DATA feature
> >
> >
> > ---
> >  hw/net/vhost_net.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index
> > e8e1661646..211ca859a6 100644
> > --- a/hw/net/vhost_net.c
> > +++ b/hw/net/vhost_net.c
> > @@ -76,6 +76,8 @@ static const int user_feature_bits[] = {
> >      VIRTIO_F_IOMMU_PLATFORM,
> >      VIRTIO_F_RING_PACKED,
> >      VIRTIO_F_RING_RESET,
> > +    VIRTIO_F_IN_ORDER,
> > +    VIRTIO_F_NOTIFICATION_DATA,
> >      VIRTIO_NET_F_RSS,
> >      VIRTIO_NET_F_HASH_REPORT,
> >      VIRTIO_NET_F_GUEST_USO4,
> > --
> >
> > -----Original Message-----
> > From: Wentao Jia
> > Sent: Tuesday, January 2, 2024 1:38 PM
> > To: Jason Wang <jasowang@redhat.com>
> > Cc: mst@redhat.com; Rick Zhong <zhaoyong.zhong@nephogine.com>
> > Subject: RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
> > VIRTIO_F_NOTIFICATION_DATA feature
> >
> > Hi, Jason
> >
> > It is good just change feature bits, I will commit a new patch, 
> > thanks
> >
> > Wentao Jia
> >
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Tuesday, January 2, 2024 11:24 AM
> > To: Wentao Jia <wentao.jia@nephogine.com>
> > Cc: mst@redhat.com; Rick Zhong <zhaoyong.zhong@nephogine.com>
> > Subject: Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
> > VIRTIO_F_NOTIFICATION_DATA feature
> >
> > On Tue, Jan 2, 2024 at 10:26 AM Wentao Jia <wentao.jia@nephogine.com> wrote:
> > >
> > > Hi, Michael  and Jason
> > >
> > >
> > >
> > > please review the patch at your convenience, thank you
> > >
> > > vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA 
> > > feature - Patchwork (kernel.org)
> > >
> > >
> > >
> > > Wentao Jia
> > >
> > >
> > >
> > > From: Wentao Jia
> > > Sent: Friday, December 1, 2023 6:11 PM
> > > To: qemu-devel@nongnu.org
> > > Subject: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and 
> > > VIRTIO_F_NOTIFICATION_DATA feature
> > >
> > >
> > >
> > > VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature are 
> > > important feature
> > >
> > > for dpdk vdpa packets transmitting performance, add the 2 features 
> > > at vhost-user
> > >
> > > front-end to negotiation with backend.
> > >
> > >
> > >
> > > Signed-off-by: Kyle Xu zhenbing.xu@corigine.com
> > >
> > > Signed-off-by: Wentao Jia wentao.jia@corigine.com
> > >
> > > Reviewed-by:   Xinying Yu xinying.yu@corigine.com
> > >
> > > Reviewed-by:   Shujing Dong shujing.dong@corigine.com
> > >
> > > Reviewed-by:   Rick Zhong zhaoyong.zhong@corigine.com
> > >
> > > ---
> > >
> > > hw/net/vhost_net.c         | 2 ++
> > >
> > > include/hw/virtio/virtio.h | 4 ++++
> > >
> > > 2 files changed, 6 insertions(+)
> > >
> > >
> > >
> > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> > >
> > > index e8e1661646..211ca859a6 100644
> > >
> > > --- a/hw/net/vhost_net.c
> > >
> > > +++ b/hw/net/vhost_net.c
> > >
> > > @@ -76,6 +76,8 @@ static const int user_feature_bits[] = {
> > >
> > >      VIRTIO_F_IOMMU_PLATFORM,
> > >
> > >      VIRTIO_F_RING_PACKED,
> > >
> > >      VIRTIO_F_RING_RESET,
> > >
> > > +    VIRTIO_F_IN_ORDER,
> > >
> > > +    VIRTIO_F_NOTIFICATION_DATA,
> > >
> > >      VIRTIO_NET_F_RSS,
> > >
> > >      VIRTIO_NET_F_HASH_REPORT,
> > >
> > >      VIRTIO_NET_F_GUEST_USO4,
> > >
> > > diff --git a/include/hw/virtio/virtio.h 
> > > b/include/hw/virtio/virtio.h
> > >
> > > index c8f72850bc..3880b6764c 100644
> > >
> > > --- a/include/hw/virtio/virtio.h
> > >
> > > +++ b/include/hw/virtio/virtio.h
> > >
> > > @@ -369,6 +369,10 @@ typedef struct VirtIORNGConf VirtIORNGConf;
> > >
> > >                        VIRTIO_F_RING_PACKED, false), \
> > >
> > >      DEFINE_PROP_BIT64("queue_reset", _state, _field, \
> > >
> > >                        VIRTIO_F_RING_RESET, true)
> > >
> > > +    DEFINE_PROP_BIT64("notification_data", _state, _field, \
> > >
> > > +                      VIRTIO_F_NOTIFICATION_DATA, true), \
> > >
> > > +    DEFINE_PROP_BIT64("in_order", _state, _field, \
> > >
> > > +                      VIRTIO_F_IN_ORDER, true)
> >
> > Do we want compatibility support for those?
> >
> > Thanks
> >
> > >
> > >
> > >
> > > hwaddr virtio_queue_get_desc_addr(VirtIODevice *vdev, int n);
> > >
> > > bool virtio_queue_enabled_legacy(VirtIODevice *vdev, int n);
> > >
> > > --
> >
>