Re: [PULL 39/41] hw/net/cadence_gem: use FIELD to describe PHYMNTNC register fields

[Guenter Roeck]

Hi,

On Fri, Oct 27, 2023 at 03:39:40PM +0100, Peter Maydell wrote:
> From: Luc Michel <luc.michel@amd.com>
> 
> Use the FIELD macro to describe the PHYMNTNC register fields.
> 
> Signed-off-by: Luc Michel <luc.michel@amd.com>
> Reviewed-by: sai.pavan.boddu@amd.com
> Message-id: 20231017194422.4124691-10-luc.michel@amd.com
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

With qemu v8.2.0 and this patch in place, I get the following error when trying
to enable the network interface on the xilinx-zynq-a9 emulation.

macb e000b000.ethernet eth0: validation of  with support 
00,00000000,00005000,00006000 and advertisement 00,00000000,00000000,00000000 
failed: -EINVAL
macb e000b000.ethernet eth0: Could not attach PHY (-22)

The problem is gone after reverting this patch. Note that I also had
to revert "hw/net/cadence_gem: perform PHY access on write only", but
that alone did not fix the problem.

Guenter