[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 01/12] cxl/cdat: Handle cdat table build errors
|
From: |
Jonathan Cameron |
|
Subject: |
[PATCH 01/12] cxl/cdat: Handle cdat table build errors |
|
Date: |
Wed, 24 Jan 2024 12:40:49 +0000 |
From: Ira Weiny <ira.weiny@intel.com>
The callback for building CDAT tables may return negative error codes.
This was previously unhandled and will result in potentially huge
allocations later on in ct3_build_cdat()
Detect the negative error code and defer cdat building.
Fixes: f5ee7413d592 ("hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange")
Cc: Huai-Cheng Kuo <hchkuo@avery-design.com.tw>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/cxl/cxl-cdat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c
index 639a2db3e1..24829cf242 100644
--- a/hw/cxl/cxl-cdat.c
+++ b/hw/cxl/cxl-cdat.c
@@ -63,7 +63,7 @@ static void ct3_build_cdat(CDATObject *cdat, Error **errp)
cdat->built_buf_len = cdat->build_cdat_table(&cdat->built_buf,
cdat->private);
- if (!cdat->built_buf_len) {
+ if (cdat->built_buf_len <= 0) {
/* Build later as not all data available yet */
cdat->to_update = true;
return;
--
2.39.2
- [PATCH 00/12 qemu] CXL emulation fixes and minor cleanup., Jonathan Cameron, 2024/01/24
- [PATCH 01/12] cxl/cdat: Handle cdat table build errors,
Jonathan Cameron <=
- [PATCH 02/12] hw/mem/cxl_type3: Drop handling of failure of g_malloc0(), Jonathan Cameron, 2024/01/24
- [PATCH 03/12] hw/pci-bridge/cxl_upstream: Drop g_malloc0() failure handling, Jonathan Cameron, 2024/01/24
- [PATCH 04/12] cxl/cdat: Fix header sum value in CDAT checksum, Jonathan Cameron, 2024/01/24
- [PATCH 05/12] hw/cxl/mbox: Remove dead code, Jonathan Cameron, 2024/01/24
- [PATCH 06/12] hw/cxl/device: read from register values in mdev_reg_read(), Jonathan Cameron, 2024/01/24
- [PATCH 07/12] hw/cxl: Pass CXLComponentState to cache_mem_ops, Jonathan Cameron, 2024/01/24