Re: [PATCH] tests/unit: Bump test-replication timeout to 45 seconds

[Thomas Huth]

On 25/01/2024 17.58, Kevin Wolf wrote:
> We're seeing timeouts for this test on CI runs (specifically for
> ubuntu-20.04-s390x-all). It doesn't fail consistently, but even the
> successful runs take about 27 or 28 seconds, which is not very far from
> the 30 seconds timeout.
>
> Bump the timeout a bit to make failure less likely even on this CI host.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   tests/unit/meson.build | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/meson.build b/tests/unit/meson.build
> index 0659532122..db6398a0f4 100644
> --- a/tests/unit/meson.build
> +++ b/tests/unit/meson.build
> @@ -175,7 +175,8 @@ slow_tests = {
>     'test-aio-multithread' : 120,
>     'test-crypto-block' : 300,
>     'test-crypto-tlscredsx509': 45,
> -  'test-crypto-tlssession': 45
> +  'test-crypto-tlssession': 45,
> +  'test-replication': 45,
>   }
>   
>   foreach test_name, extra: tests

I'd maybe even bump it to 60 seconds, just to be on the safe side.

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>