[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64
From: |
peterx |
Subject: |
[PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64 |
Date: |
Fri, 26 Jan 2024 12:17:16 +0800 |
From: Fabiano Rosas <farosas@suse.de>
The 'max' cpu is not expected to be stable in terms of features across
QEMU versions, so it should not be expected to migrate.
While the tests currently all pass with -cpu max, that is only because
we're not testing across QEMU versions, which is the more common
use-case for migration.
We've recently introduced compatibility tests that use two different
QEMU versions and the tests are now failing for aarch64. The next
patch adds those tests to CI, so we cannot use the 'max' cpu
anymore. Replace it with the 'neoverse-n1', which has a fixed set of
features.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: 20240118164951.30350-2-farosas@suse.de">https://lore.kernel.org/r/20240118164951.30350-2-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 7675519cfa..15713f3666 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -820,7 +820,7 @@ static int test_migrate_start(QTestState **from, QTestState
**to,
memory_size = "150M";
machine_alias = "virt";
machine_opts = "gic-version=max";
- arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath);
+ arch_opts = g_strdup_printf("-cpu neoverse-n1 -kernel %s", bootpath);
start_address = ARM_TEST_MEM_START;
end_address = ARM_TEST_MEM_END;
} else {
--
2.43.0
- [PULL 00/15] Migration 20240126 patches, peterx, 2024/01/25
- [PULL 01/15] userfaultfd: use 1ULL to build ioctl masks, peterx, 2024/01/25
- [PULL 02/15] migration: Plug memory leak on HMP migrate error path, peterx, 2024/01/25
- [PULL 03/15] migration: Make threshold_size an uint64_t, peterx, 2024/01/25
- [PULL 04/15] migration: Drop unnecessary check in ram's pending_exact(), peterx, 2024/01/25
- [PULL 05/15] analyze-migration.py: Remove trick on parsing ramblocks, peterx, 2024/01/25
- [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64,
peterx <=
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Fabiano Rosas, 2024/01/26
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Peter Maydell, 2024/01/26
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Fabiano Rosas, 2024/01/26
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Peter Xu, 2024/01/28
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Fabiano Rosas, 2024/01/29
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Fabiano Rosas, 2024/01/29
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Peter Maydell, 2024/01/30
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Peter Xu, 2024/01/30
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Fabiano Rosas, 2024/01/30
- Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64, Peter Xu, 2024/01/30