[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/33] tests/tcg: Factor out gdbstub test functions
|
From: |
Ilya Leoshkevich |
|
Subject: |
Re: [PATCH 14/33] tests/tcg: Factor out gdbstub test functions |
|
Date: |
Mon, 29 Jan 2024 10:38:39 +0100 |
On Sun, Jan 28, 2024 at 02:41:54PM +1000, Richard Henderson wrote:
> From: Ilya Leoshkevich <iii@linux.ibm.com>
>
> Both the report() function as well as the initial gdbstub test sequence
> are copy-pasted into ~10 files with slight modifications. This
> indicates that they are indeed generic, so factor them out. While
> at it, add a few newlines to make the formatting closer to PEP-8.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> Message-Id: <20240109230808.583012-3-iii@linux.ibm.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/guest-debug/run-test.py | 7 ++-
> tests/guest-debug/test_gdbstub.py | 56 +++++++++++++++++++
> tests/tcg/aarch64/gdbstub/test-sve-ioctl.py | 34 +----------
> tests/tcg/aarch64/gdbstub/test-sve.py | 33 +----------
> tests/tcg/multiarch/gdbstub/interrupt.py | 47 ++--------------
> tests/tcg/multiarch/gdbstub/memory.py | 39 +------------
> tests/tcg/multiarch/gdbstub/registers.py | 41 ++------------
> tests/tcg/multiarch/gdbstub/sha1.py | 38 ++-----------
> .../multiarch/gdbstub/test-proc-mappings.py | 39 +------------
> .../multiarch/gdbstub/test-qxfer-auxv-read.py | 37 +-----------
> .../gdbstub/test-thread-breakpoint.py | 37 +-----------
> tests/tcg/s390x/gdbstub/test-signals-s390x.py | 42 +-------------
> tests/tcg/s390x/gdbstub/test-svc.py | 39 +------------
> 13 files changed, 94 insertions(+), 395 deletions(-)
> create mode 100644 tests/guest-debug/test_gdbstub.py
Alex had issues with this and the next patch, I posted an update that
hopefully resolves them:
20240129093410.3151-1-iii@linux.ibm.com/">https://lore.kernel.org/qemu-devel/20240129093410.3151-1-iii@linux.ibm.com/
- Re: [PATCH 07/33] target: Uninline cpu_mmu_index(), (continued)
- [PATCH 09/33] include/exec: Move PAGE_* macros to common header, Richard Henderson, 2024/01/27
- [PATCH 08/33] target: Uninline cpu_get_tb_cpu_state(), Richard Henderson, 2024/01/27
- [PATCH 10/33] include/exec: Move cpu_*()/cpu_env() to common header, Richard Henderson, 2024/01/27
- [PATCH 11/33] include/hw/core: Move do_interrupt in TCGCPUOps, Richard Henderson, 2024/01/27
- [PATCH 12/33] include/hw/core: Remove i386 conditional on fake_user_interrupt, Richard Henderson, 2024/01/27
- [PATCH 13/33] linux-user: Allow gdbstub to ignore page protection, Richard Henderson, 2024/01/27
- [PATCH 14/33] tests/tcg: Factor out gdbstub test functions, Richard Henderson, 2024/01/27
- Re: [PATCH 14/33] tests/tcg: Factor out gdbstub test functions,
Ilya Leoshkevich <=
- [PATCH 15/33] tests/tcg: Add the PROT_NONE gdbstub test, Richard Henderson, 2024/01/27
- [PATCH 16/33] accel/tcg/cpu-exec: Use RCU_READ_LOCK_GUARD, Richard Henderson, 2024/01/27
- [PATCH 17/33] target: Make qemu_target_page_mask() available for *-user, Richard Henderson, 2024/01/27
- [PATCH 18/33] accel/tcg: Make use of qemu_target_page_mask() in perf.c, Richard Henderson, 2024/01/27
- [PATCH 19/33] tcg: Make tb_cflags() usable from target-agnostic code, Richard Henderson, 2024/01/27
- [PATCH 20/33] accel/tcg: Remove #ifdef TARGET_I386 from perf.c, Richard Henderson, 2024/01/27
- [PATCH 21/33] accel/tcg: Move perf and debuginfo support to tcg/, Richard Henderson, 2024/01/27
- [PATCH 22/33] accel/tcg: Rename tcg_ss[] -> tcg_specific_ss[] in meson, Richard Henderson, 2024/01/27
- [PATCH 23/33] accel/tcg: Rename tcg_cpus_destroy() -> tcg_cpu_destroy(), Richard Henderson, 2024/01/27