Re: [PATCH 33/33] include/exec: Change cpu_mmu

qemu-devel

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUStat

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState
Date:	Tue, 30 Jan 2024 12:29:19 +0100
User-agent:	Mozilla Thunderbird

On 30/1/24 12:05, Richard Henderson wrote:

On 1/30/24 18:26, Philippe Mathieu-Daudé wrote:

What is the rationale here? (I'm trying to generically understand
in which case one is better than another).


Didn't you ask Anton why a generic cpu_* function was using CPUArchState?

Anyway, I think we've generally used CPUState more often with genericfunctions, and this should follow.


Yes I concur. I thought maybe you figured another benefit I
didn't noticed yet, that would be useful to document elsewhere.

Current Thread

[Next in Thread]

[PATCH 28/33] target/sh4: Populate CPUClass.mmu_index, (continued)
- [PATCH 28/33] target/sh4: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 29/33] target/sparc: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 32/33] include/exec: Implement cpu_mmu_index generically, Richard Henderson, 2024/01/29
  - Re: [PATCH 32/33] include/exec: Implement cpu_mmu_index generically, Philippe Mathieu-Daudé, 2024/01/30
- [PATCH 30/33] target/tricore: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 26/33] target/s390x: Split out s390x_env_mmu_index, Richard Henderson, 2024/01/29
- [PATCH 31/33] target/xtensa: Populate CPUClass.mmu_index, Richard Henderson, 2024/01/29
- [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Richard Henderson, 2024/01/29
  - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Philippe Mathieu-Daudé, 2024/01/30
    - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Richard Henderson, 2024/01/30
    - Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState, Philippe Mathieu-Daudé <=
- Re: [PATCH 00/33] hw/core: Introduce CPUClass hook for mmu_index, Philippe Mathieu-Daudé, 2024/01/30
- Re: [PATCH 00/33] hw/core: Introduce CPUClass hook for mmu_index, Anton Johansson, 2024/01/30