[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/arm: fix exception syndrome for AArch32 bkpt insn
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2] target/arm: fix exception syndrome for AArch32 bkpt insn |
|
Date: |
Tue, 30 Jan 2024 16:48:19 +0000 |
On Sat, 27 Jan 2024 at 20:30, Jan Klötzke <jan.kloetzke@kernkonzept.com> wrote:
>
> Debug exceptions that target AArch32 Hyp mode are reported differently
> than on AAarch64. Internally, Qemu uses the AArch64 syndromes. Therefore
> such exceptions need to be either converted to a prefetch abort
> (breakpoints, vector catch) or a data abort (watchpoints).
>
> Signed-off-by: Jan Klötzke <jan.kloetzke@kernkonzept.com>
> ---
> v2:
> * Refactor watchpoint syndrome rewriting
> * Drop ARM_EL_ISV from watchpoint syndrome
>
> target/arm/helper.c | 18 ++++++++++++++++++
> target/arm/syndrome.h | 8 ++++++++
> 2 files changed, 26 insertions(+)
>
Applied to target-arm.next, thanks (with a cc: qemu-stable header added).
By the way, if you're interested in incorrect syndromes with
AArch32 Hyp mode, the other one I know about is
https://gitlab.com/qemu-project/qemu/-/issues/1153
which describes some issues with the syndrome for traps
of VFP or Neon instructions. I don't know if that affects
your use-case.
thanks
-- PMM