[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons
|
From: |
Richard Henderson |
|
Subject: |
[PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons |
|
Date: |
Tue, 12 Mar 2024 08:41:14 -1000 |
Pass the type to tcg_out_logicali; remove the assert, duplicated
at the start of tcg_out_logicali.
Fixes: 339adf2f38e ("tcg/aarch64: Support TCG_COND_TST{EQ,NE}")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/aarch64/tcg-target.c.inc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index dec8ecc1b6..38446c167e 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1388,8 +1388,7 @@ static void tcg_out_cmp(TCGContext *s, TCGType ext,
TCGCond cond, TCGReg a,
if (!const_b) {
tcg_out_insn(s, 3510, ANDS, ext, TCG_REG_XZR, a, b);
} else {
- tcg_debug_assert(is_limm(b));
- tcg_out_logicali(s, I3404_ANDSI, 0, TCG_REG_XZR, a, b);
+ tcg_out_logicali(s, I3404_ANDSI, ext, TCG_REG_XZR, a, b);
}
} else {
if (!const_b) {
--
2.34.1
- [PULL 0/8] tcg + linux-user patch queue, Richard Henderson, 2024/03/12
- [PULL 1/8] linux-user: Add FIFREEZE and FITHAW ioctls, Richard Henderson, 2024/03/12
- [PULL 3/8] linux-user: Implement PR_{GET,SET}_SPECULATION_CTRL, Richard Henderson, 2024/03/12
- [PULL 2/8] linux-user: Implement PR_{GET,SET}_CHILD_SUBREAPER, Richard Henderson, 2024/03/12
- [PULL 4/8] linux-user: Implement PR_GET_TID_ADDRESS, Richard Henderson, 2024/03/12
- [PULL 8/8] tcg/aarch64: Fix tcg_out_brcond for test comparisons, Richard Henderson, 2024/03/12
- [PULL 6/8] linux-user/elfload: Fully initialize struct target_elf_prpsinfo, Richard Henderson, 2024/03/12
- [PULL 5/8] linux-user/elfload: Don't close an unopened file descriptor, Richard Henderson, 2024/03/12
- [PULL 7/8] tcg/aarch64: Fix tcg_out_cmp for test comparisons,
Richard Henderson <=
- Re: [PULL 0/8] tcg + linux-user patch queue, Peter Maydell, 2024/03/13