[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_stat
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup() |
|
Date: |
Fri, 15 Mar 2024 09:11:56 -0400 |
On Fri, Mar 15, 2024 at 01:20:49PM +0100, Cédric Le Goater wrote:
> +static void qemu_savevm_wait_unplug(MigrationState *s, int state)
One more trivial comment: I'd even consider dropping "state" altogether, as
this should be the only state this function should be invoked. So we can
perhaps assert it instead of passing it over?
--
Peter Xu
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), (continued)
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/12
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Fabiano Rosas, 2024/03/12
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Peter Xu, 2024/03/12
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/12
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Fabiano Rosas, 2024/03/12
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Peter Xu, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Peter Xu, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(),
Peter Xu <=
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Peter Xu, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Cédric Le Goater, 2024/03/15
- Re: [PATCH v4 10/25] migration: Add Error** argument to qemu_savevm_state_setup(), Peter Xu, 2024/03/15
[PATCH v4 08/25] migration: Always report an error in ram_save_setup(), Cédric Le Goater, 2024/03/06
[PATCH v4 06/25] vfio: Always report an error in vfio_save_setup(), Cédric Le Goater, 2024/03/06
[PATCH v4 12/25] migration: Add Error** argument to .load_setup() handler, Cédric Le Goater, 2024/03/06
[PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler, Cédric Le Goater, 2024/03/06