Re: assert fails in s390x TCG

[Claudio Fontana]

On 6/12/24 14:41, Philippe Mathieu-Daudé wrote:
> On 28/7/23 18:43, Richard Henderson wrote:
>> On 7/28/23 09:05, Richard Henderson wrote:
>>> It's the page containing both code and a page table entry that 
>>> concerns me.  It seems like a kernel bug, though obviously we 
>>> shouldn't crash.  I'm not sure what to do about it.
>>
>> Bah.  Of course it's not a kernel bug, since the store is to LowCore.
>> And of course LowCore is part of a larger page, which easily has other 
>> stuff.
> 
> Maybe related to
> 20240611215814.32752-1-anjo@rev.ng/">https://lore.kernel.org/qemu-devel/20240611215814.32752-1-anjo@rev.ng/
> 

Hi philippe,

this was already fixed by Ilya's commit:

commit 791b2b6a930273db694b9ba48bbb406e78715927
Author: Ilya Leoshkevich <iii@linux.ibm.com>
Date:   Sat Aug 5 01:03:18 2023 +0200

    target/s390x: Fix the "ignored match" case in VSTRS
    
    Currently the emulation of VSTRS recognizes partial matches in presence
    of \0 in the haystack, which, according to PoP, is not correct:
    
        If the ZS flag is one and a zero byte was detected
        in the second operand, then there can not be a
        partial match ...
    
    Add a check for this. While at it, fold a number of explicitly handled
    special cases into the generic logic.
    
    Cc: qemu-stable@nongnu.org
    Reported-by: Claudio Fontana <cfontana@suse.de>
    Closes: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg00633.html
    Fixes: 1d706f314191 ("target/s390x: vxeh2: vector string search")
    Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
    Message-Id: <20230804233748.218935-3-iii@linux.ibm.com>
    Tested-by: Claudio Fontana <cfontana@suse.de>
    Acked-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: Thomas Huth <thuth@redhat.com>

Ciao,

Claudio