[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/15] tests/unit/test-smp-parse: Make test cases aware of module
From: |
Thomas Huth |
Subject: |
[PULL 11/15] tests/unit/test-smp-parse: Make test cases aware of module level |
Date: |
Wed, 12 Jun 2024 15:20:51 +0200 |
From: Zhao Liu <zhao1.liu@intel.com>
Currently, -smp supports module level.
It is necessary to consider the effects of module in the test cases to
ensure that the calculations are correct. This is also the preparation
to add module test cases.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Yongwei Ma <yongwei.ma@intel.com>
Message-ID: <20240529061925.350323-6-zhao1.liu@intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-smp-parse.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index e3a0a9d12d..2214e47ba9 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -629,6 +629,7 @@ static char *smp_config_to_string(const SMPConfiguration
*config)
" .has_sockets = %5s, sockets = %" PRId64 ",\n"
" .has_dies = %5s, dies = %" PRId64 ",\n"
" .has_clusters = %5s, clusters = %" PRId64 ",\n"
+ " .has_modules = %5s, modules = %" PRId64 ",\n"
" .has_cores = %5s, cores = %" PRId64 ",\n"
" .has_threads = %5s, threads = %" PRId64 ",\n"
" .has_maxcpus = %5s, maxcpus = %" PRId64 ",\n"
@@ -639,6 +640,7 @@ static char *smp_config_to_string(const SMPConfiguration
*config)
config->has_sockets ? "true" : "false", config->sockets,
config->has_dies ? "true" : "false", config->dies,
config->has_clusters ? "true" : "false", config->clusters,
+ config->has_modules ? "true" : "false", config->modules,
config->has_cores ? "true" : "false", config->cores,
config->has_threads ? "true" : "false", config->threads,
config->has_maxcpus ? "true" : "false", config->maxcpus);
@@ -679,6 +681,7 @@ static char *cpu_topology_to_string(const CpuTopology *topo,
" .sockets = %u,\n"
" .dies = %u,\n"
" .clusters = %u,\n"
+ " .modules = %u,\n"
" .cores = %u,\n"
" .threads = %u,\n"
" .max_cpus = %u,\n"
@@ -688,8 +691,8 @@ static char *cpu_topology_to_string(const CpuTopology *topo,
"}",
topo->cpus, topo->drawers, topo->books,
topo->sockets, topo->dies, topo->clusters,
- topo->cores, topo->threads, topo->max_cpus,
- threads_per_socket, cores_per_socket,
+ topo->modules, topo->cores, topo->threads,
+ topo->max_cpus, threads_per_socket, cores_per_socket,
has_clusters ? "true" : "false");
}
@@ -732,6 +735,7 @@ static void check_parse(MachineState *ms, const
SMPConfiguration *config,
(ms->smp.sockets == expect_topo->sockets) &&
(ms->smp.dies == expect_topo->dies) &&
(ms->smp.clusters == expect_topo->clusters) &&
+ (ms->smp.modules == expect_topo->modules) &&
(ms->smp.cores == expect_topo->cores) &&
(ms->smp.threads == expect_topo->threads) &&
(ms->smp.max_cpus == expect_topo->max_cpus) &&
@@ -812,6 +816,11 @@ static void smp_parse_test(MachineState *ms, SMPTestData
*data, bool is_valid)
/* The parsed results of the unsupported parameters should be 1 */
static void unsupported_params_init(const MachineClass *mc, SMPTestData *data)
{
+ if (!mc->smp_props.modules_supported) {
+ data->expect_prefer_sockets.modules = 1;
+ data->expect_prefer_cores.modules = 1;
+ }
+
if (!mc->smp_props.dies_supported) {
data->expect_prefer_sockets.dies = 1;
data->expect_prefer_cores.dies = 1;
--
2.45.2
- [PULL 00/15] CPU-related test updates, Thomas Huth, 2024/06/12
- [PULL 01/15] tests/avocado: Update LoongArch bios file, Thomas Huth, 2024/06/12
- [PULL 03/15] tests/qtest/libqtest: add qtest_has_cpu_model() api, Thomas Huth, 2024/06/12
- [PULL 02/15] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu, Thomas Huth, 2024/06/12
- [PULL 04/15] tests/qtest/x86: check for availability of older cpu models before running tests, Thomas Huth, 2024/06/12
- [PULL 05/15] meson: Remove libibumad dependence, Thomas Huth, 2024/06/12
- [PULL 06/15] test: Remove libibumad dependence, Thomas Huth, 2024/06/12
- [PULL 10/15] tests/unit/test-smp-parse: Use default parameters=0 when not set in -smp, Thomas Huth, 2024/06/12
- [PULL 11/15] tests/unit/test-smp-parse: Make test cases aware of module level,
Thomas Huth <=
- [PULL 09/15] tests/unit/test-smp-parse: Fix an invalid topology case, Thomas Huth, 2024/06/12
- [PULL 08/15] tests/unit/test-smp-parse: Fix comment of parameters=1 case, Thomas Huth, 2024/06/12
- [PULL 13/15] tests/unit/test-smp-parse: Test "modules" and "dies" combination case, Thomas Huth, 2024/06/12
- [PULL 07/15] tests/unit/test-smp-parse: Fix comments of drawers and books case, Thomas Huth, 2024/06/12
- [PULL 15/15] tests/tcg/s390x: Allow specifying extra QEMU options on the command line, Thomas Huth, 2024/06/12
- [PULL 14/15] tests/unit/test-smp-parse: Test the full 8-levels topology hierarchy, Thomas Huth, 2024/06/12
- [PULL 12/15] tests/unit/test-smp-parse: Test "modules" parameter in -smp, Thomas Huth, 2024/06/12
- Re: [PULL 00/15] CPU-related test updates, Richard Henderson, 2024/06/14