Re: [PATCH v3 1/7] HostIOMMUDevice: Store the VFIO/VDPA agent

[Cédric Le Goater]

> > Talking of which, why are we passing a 'VFIODevice *' parameter to
> > HostIOMMUDeviceClass::realize ? I don't see a good reason
> >
> > I think a 'VFIOContainerBase *' would be more appropriate since
> > 'HostIOMMUDevice' represents a device on the host which is common
> > to all VFIO devices.
> >   
> > In that case, HostIOMMUDevice::agent wouldn't need to be opaque
> > anymore. It could  simply be a 'VFIOContainerBase *' and
> > hiod_legacy_vfio_get_iova_ranges() in patch 3 would grab the
> > 'iova_ranges' from the 'VFIOContainerBase *' directly.
> >
> > This means some rework :
> >
> > * vfio_device_get_aw_bits() would use a  'VFIOContainerBase *' instead.
> > * HostIOMMUDevice::name would be removed. This is just for error
> > messages.
> > * hiod_iommufd_vfio_realize() would use VFIOIOMMUFDContainer::be.
> >
> > That said, I think we need the QOMification changes first.
>
> OK I need to review your series first. At the moment I have just
> addressed Zhenzhong's comment in v4, just sent.

Yep. Just take a look at mine. If both of you agree with above
proposal, I can care of it and resend all 3. It's a small change.

Thanks,

C.