Re: [PULL 00/19] aspeed queue

[Cédric Le Goater]

On 6/15/24 6:14 PM, Richard Henderson wrote:
> On 6/14/24 00:26, Cédric Le Goater wrote:
> > The following changes since commit 046a64b9801343e2e89eef10c7a48eec8d8c0d4f:
> >
> >    Merge tag 'pull-request-2024-06-12' of https://gitlab.com/thuth/qemu into 
> > staging (2024-06-13 07:51:58 -0700)
> >
> > are available in the Git repository at:
> >
> >    https://github.com/legoater/qemu/ tags/pull-aspeed-20240614
> >
> > for you to fetch changes up to d9f6311f5393da897e73be8a29c261125d0c1ac2:
> >
> >    MAINTAINERS: Add reviewers for ASPEED BMCs (2024-06-14 07:36:09 +0200)
> >
> > ----------------------------------------------------------------
> > aspeed queue:
> >
> > * Add AST2700 support
>
> Fails freebsd testing:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/7106081732
>
> I'm not sure off hand why this wouldn't also fail on Linux...

Yep. It should have :

@@ -332,6 +332,7 @@ static const TypeInfo aspeed_intc_info =
     .instance_init = aspeed_intc_instance_init,
     .instance_size = sizeof(AspeedINTCState),
     .class_init = aspeed_intc_class_init,
+    .class_size    = sizeof(AspeedINTCClass),
     .abstract = true,
 };


I will resend a v2 next week.

C.