Re: [PATCH] Make TARGET_PAGE_MASK typed as target_ulong

[Roman Kiryanov]

Hi Richard,

thank you for looking into this.

> No, this will cause failures, because we need this value to sign-extend to 
> when the
> context includes {u}int64_t, and target_ulong is uint32_t.

I did not expect this, good catch. I see QEMU uses size_t as the
return type in qemu_target_page_size which returns TARGET_PAGE_SIZE.
Maybe use size_t for TARGET_PAGE_MASK everywhere (including
qemu_target_page_mask) as well?

> What options are you using, because this warning should not be generated with 
> -fwrapv.

Good point, I think we missed this option.

Regards,
Roman.