[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/10] target/i386: list instructions still in translate.c
From: |
Paolo Bonzini |
Subject: |
[PATCH 08/10] target/i386: list instructions still in translate.c |
Date: |
Thu, 20 Jun 2024 11:54:17 +0200 |
Group them so that it is easier to figure out which two-byte opcodes to
tackle together.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/decode-new.c.inc | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
index fa51aadfcf2..f01a4f1f1fe 100644
--- a/target/i386/tcg/decode-new.c.inc
+++ b/target/i386/tcg/decode-new.c.inc
@@ -129,6 +129,37 @@
*
* (^) these are the two cases in which Intel and AMD disagree on the
* primary exception class
+ *
+ * Instructions still in translate.c
+ * ---------------------------------
+ * Generation of TCG opcodes for almost all instructions is in emit.c.inc;
+ * this file interprets the prefixes and opcode bytes down to individual
+ * instruction mnemonics. There is only a handful of opcodes still using
+ * a switch statement to decode modrm bits 3-5 and prefixes after decoding
+ * is complete; these are relics of the older x86 decoder and their code
+ * generation is performed in translate.c.
+ *
+ * These unconverted opcodes also perform their own effective address
+ * generation using the gen_lea_modrm() function.
+ *
+ * There is nothing particularly complicated about them; simply, they don't
+ * need any nasty hacks in the decoder, and they shouldn't get in the way
+ * of the implementation of new x86 instructions, so they are left alone
+ * for the time being.
+ *
+ * x87:
+ * 0xD8 - 0xDF
+ *
+ * privileged/system:
+ * 0x0F 0x00 group 6 (SLDT, STR, LLDT, LTR, VERR, VERW)
+ * 0x0F 0x01 group 7 (SGDT, SIDT, LGDT, LIDT, SMSW, LMSW, INVLPG,
+ * MONITOR, MWAIT, CLAC, STAC, XGETBV, XSETBV,
+ * SWAPGS, RDTSCP)
+ * 0x0F 0xC7 (reg operand) group 9 (RDRAND, RDSEED, RDPID)
+ *
+ * MPX:
+ * 0x0F 0x1A BNDLDX, BNDMOV, BNDCL, BNDCU
+ * 0x0F 0x1B BNDSTX, BNDMOV, BNDMK, BNDCN
*/
#define X86_OP_NONE { 0 },
--
2.45.2
- [PATCH 02/10] target/i386: give CC_OP_POPCNT low bits corresponding to MO_TL, (continued)
- [PATCH 02/10] target/i386: give CC_OP_POPCNT low bits corresponding to MO_TL, Paolo Bonzini, 2024/06/20
- [PATCH 04/10] target/i386: try not to force EFLAGS computation for CC_OP_ADOX/ADCX, Paolo Bonzini, 2024/06/20
- [PATCH 03/10] target/i386: convert bit test instructions to new decoder, Paolo Bonzini, 2024/06/20
- [PATCH 05/10] target/i386: decode address before going back to translate.c, Paolo Bonzini, 2024/06/20
- [PATCH 06/10] target/i386: convert CMPXCHG8B/CMPXCHG16B to new decoder, Paolo Bonzini, 2024/06/20
- [PATCH 09/10] target/i386: assert that cc_op* and pc_save are preserved, Paolo Bonzini, 2024/06/20
- [PATCH 08/10] target/i386: list instructions still in translate.c,
Paolo Bonzini <=
- [PATCH 07/10] target/i386: do not check PREFIX_LOCK in old-style decoder, Paolo Bonzini, 2024/06/20
- [PATCH 10/10] target/i386: remove gen_ext_tl, Paolo Bonzini, 2024/06/20