[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST |
Date: |
Sat, 22 Jun 2024 10:52:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
John Snow <jsnow@redhat.com> writes:
> On Fri, Jun 21, 2024 at 8:23 AM Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> My reason for four spaces is reducing churn. To see by how much, I
>> redid your change. I found a few more notes that don't start with a
>> capital letter, or don't end with a period.
>>
>
> ^ Guess I'll re-audit for v2. Hang on to the list of cases you found.
Happy to share my patch.
> (Sorry for the churn, though. I obviously don't mind it as much as you do,
> but I suspect I'm a lot less nimble with fiddling through git history than
> you are and find the value of avoiding churn to be ... lower than you do,
> in general. Respecting reviewer time is a strong argument, I apologize that
> some non-mechanical changes snuck into the patch. The downside of hacking
> together a very large series.)
You did a good job splitting it up. Minor mistakes are bound to happen.
Got to give the reviewer soemthing to find ;)
[...]
- Re: [PATCH 08/13] qapi: ensure all errors sections are uniformly typset, (continued)
- [PATCH 10/13] qapi: update prose in note blocks, John Snow, 2024/06/18
- [PATCH 09/13] qapi: convert "Note" sections to plain rST, John Snow, 2024/06/18
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/19
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/20
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, John Snow, 2024/06/20
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, John Snow, 2024/06/20
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/21
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, John Snow, 2024/06/21
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST,
Markus Armbruster <=
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, John Snow, 2024/06/20
- Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/21
Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/19
Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/20
Re: [PATCH 09/13] qapi: convert "Note" sections to plain rST, Markus Armbruster, 2024/06/21
[PATCH 11/13] qapi: add markup to note blocks, John Snow, 2024/06/18