[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiat
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH v3 03/11] hw/acpi: Move AML building code for Generic Initiators to aml_build.c |
|
Date: |
Thu, 27 Jun 2024 08:44:14 -0400 |
On Thu, Jun 27, 2024 at 02:42:44PM +0200, Igor Mammedov wrote:
> On Thu, 20 Jun 2024 17:03:11 +0100
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > Rather than attempting to create a generic function with mess of the two
> > different device handle types, use a PCI handle specific variant. If the
> > ACPI handle form is needed then that can be introduced alongside this
> > with little duplicated code.
> >
> > Drop the PCIDeviceHandle in favor of just passing the bus, devfn
> > and segment directly. devfn kept as a single byte because ARI means
> > that in cases this is just an 8 bit function number.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Link:
> > 20240618142333.102be976@imammedo.users.ipa.redhat.com/">https://lore.kernel.org/qemu-devel/20240618142333.102be976@imammedo.users.ipa.redhat.com/
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> with typo fixed
typo being "in cases"?
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
- [PATCH v3 qemu 00/11] acpi: NUMA nodes for CXL HB as GP + complex NUMA test, Jonathan Cameron, 2024/06/20
- [PATCH v3 04/11] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator(), Jonathan Cameron, 2024/06/20
- [PATCH v3 05/11] hw/pci: Add a bus property to pci_props and use for acpi/gi, Jonathan Cameron, 2024/06/20
- [PATCH v3 06/11] acpi/pci: Move Generic Initiator object handling into acpi/pci.*, Jonathan Cameron, 2024/06/20
- [PATCH v3 07/11] hw/pci-bridge: Add acpi_uid property to CXL PXB, Jonathan Cameron, 2024/06/20