[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v42 38/98] hw/sd/sdcard: Prepare SDProto to contain more fields
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v42 38/98] hw/sd/sdcard: Prepare SDProto to contain more fields |
Date: |
Fri, 28 Jun 2024 09:01:14 +0200 |
Convert array of command handlers to array of structures.
The structure contains the command handler. No logical
change intended.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sd/sd.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index f4bdd12b26..558c39419d 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -94,8 +94,9 @@ typedef sd_rsp_type_t (*sd_cmd_handler)(SDState *sd,
SDRequest req);
typedef struct SDProto {
const char *name;
- sd_cmd_handler cmd[SDMMC_CMD_MAX];
- sd_cmd_handler acmd[SDMMC_CMD_MAX];
+ struct {
+ sd_cmd_handler handler;
+ } cmd[SDMMC_CMD_MAX], acmd[SDMMC_CMD_MAX];
} SDProto;
struct SDState {
@@ -1305,8 +1306,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
return sd_illegal;
}
- if (sd->proto->cmd[req.cmd]) {
- return sd->proto->cmd[req.cmd](sd, req);
+ if (sd->proto->cmd[req.cmd].handler) {
+ return sd->proto->cmd[req.cmd].handler(sd, req);
}
switch (req.cmd) {
@@ -1753,8 +1754,8 @@ static sd_rsp_type_t sd_app_command(SDState *sd,
req.cmd, req.arg, sd_state_name(sd->state));
sd->card_status |= APP_CMD;
- if (sd->proto->acmd[req.cmd]) {
- return sd->proto->acmd[req.cmd](sd, req);
+ if (sd->proto->acmd[req.cmd].handler) {
+ return sd->proto->acmd[req.cmd].handler(sd, req);
}
switch (req.cmd) {
@@ -2267,22 +2268,22 @@ void sd_enable(SDState *sd, bool enable)
static const SDProto sd_proto_spi = {
.name = "SPI",
.cmd = {
- [0] = sd_cmd_GO_IDLE_STATE,
- [1] = spi_cmd_SEND_OP_COND,
+ [0] = {sd_cmd_GO_IDLE_STATE},
+ [1] = {spi_cmd_SEND_OP_COND},
},
.acmd = {
- [41] = spi_cmd_SEND_OP_COND,
+ [41] = {spi_cmd_SEND_OP_COND},
},
};
static const SDProto sd_proto_sd = {
.name = "SD",
.cmd = {
- [0] = sd_cmd_GO_IDLE_STATE,
- [2] = sd_cmd_ALL_SEND_CID,
- [3] = sd_cmd_SEND_RELATIVE_ADDR,
- [19] = sd_cmd_SEND_TUNING_BLOCK,
- [23] = sd_cmd_SET_BLOCK_COUNT,
+ [0] = {sd_cmd_GO_IDLE_STATE},
+ [2] = {sd_cmd_ALL_SEND_CID},
+ [3] = {sd_cmd_SEND_RELATIVE_ADDR},
+ [19] = {sd_cmd_SEND_TUNING_BLOCK},
+ [23] = {sd_cmd_SET_BLOCK_COUNT},
},
};
--
2.41.0
- [PATCH v42 31/98] hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24), (continued)
- [PATCH v42 31/98] hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 34/98] hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 35/98] hw/sd/sdcard: Convert GEN_CMD to generic_write_byte (CMD56), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 36/98] hw/sd/sdcard: Move sd_[a]cmd_name() methods to sd.c, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 37/98] hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name(), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 38/98] hw/sd/sdcard: Prepare SDProto to contain more fields,
Philippe Mathieu-Daudé <=
- [PATCH v42 39/98] hw/sd/sdcard: Store command name in SDProto, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 40/98] hw/sd/sdcard: Store command type in SDProto, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 41/98] hw/sd/sdcard: Store command class in SDProto, Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 42/98] hw/sd/sdcard: Remove SEND_DSR dead case (CMD4), Philippe Mathieu-Daudé, 2024/06/28
- [PATCH v42 43/98] hw/sd/sdcard: Register generic optional handlers (CMD11 and CMD20), Philippe Mathieu-Daudé, 2024/06/28