[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/21] docs/qapidoc: delint a tiny portion of the module
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 04/21] docs/qapidoc: delint a tiny portion of the module |
Date: |
Fri, 28 Jun 2024 09:29:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
John Snow <jsnow@redhat.com> writes:
> In a forthcoming series that adds a new QMP documentation generator, it
> will be helpful to have a linting baseline. However, there's no need to
> shuffle around the deck chairs too much, because most of this code will
> be removed once that new qapidoc generator (the "transmogrifier") is in
> place.
>
> To ease my pain: just turn off the black auto-formatter for most, but
> not all, of qapidoc.py. This will help ensure that *new* code follows a
> coding standard without bothering too much with cleaning up the existing
> code.
>
> Code that I intend to keep is still subject to the delinting beam.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Not an objection, just so you know: I still see a few C0411 like 'third
party import "import sphinx" should be placed before ...'
R-by stands.
- [PATCH v2 00/21] qapi: convert "Note" and "Example" sections to rST, John Snow, 2024/06/26
- [PATCH v2 01/21] [DO-NOT-MERGE]: Add some ad-hoc linting helpers., John Snow, 2024/06/26
- [PATCH v2 02/21] qapi: linter fixups, John Snow, 2024/06/26
- [PATCH v2 03/21] docs/qapidoc: remove unused intersperse function, John Snow, 2024/06/26
- [PATCH v2 04/21] docs/qapidoc: delint a tiny portion of the module, John Snow, 2024/06/26
- Re: [PATCH v2 04/21] docs/qapidoc: delint a tiny portion of the module,
Markus Armbruster <=
- [PATCH v2 05/21] qapi/parser: preserve indentation in QAPIDoc sections, John Snow, 2024/06/26
- [PATCH v2 06/21] qapi/parser: fix comment parsing immediately following a doc block, John Snow, 2024/06/26
- [PATCH v2 07/21] docs/qapidoc: fix nested parsing under untagged sections, John Snow, 2024/06/26