[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/16] vl: Allow multiple -overcommit commands
From: |
Michael Tokarev |
Subject: |
[PULL 03/16] vl: Allow multiple -overcommit commands |
Date: |
Sun, 30 Jun 2024 19:53:13 +0300 |
From: Zide Chen <zide.chen@intel.com>
Both cpu-pm and mem-lock are related to system resource overcommit, but
they are separate from each other, in terms of how they are realized,
and of course, they are applied to different system resources.
It's tempting to use separate command lines to specify their behavior.
e.g., in the following example, the cpu-pm command is quietly
overwritten, and it's not easy to notice it without careful inspection.
--overcommit mem-lock=on
--overcommit cpu-pm=on
Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option")
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Zide Chen <zide.chen@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
system/vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/system/vl.c b/system/vl.c
index cfcb674425..4dc862652f 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -3546,8 +3546,8 @@ void qemu_init(int argc, char **argv)
if (!opts) {
exit(1);
}
- enable_mlock = qemu_opt_get_bool(opts, "mem-lock", false);
- enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", false);
+ enable_mlock = qemu_opt_get_bool(opts, "mem-lock",
enable_mlock);
+ enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm",
enable_cpu_pm);
break;
case QEMU_OPTION_compat:
{
--
2.39.2
- [PULL 00/16] Trivial patches for 2024-06-30, Michael Tokarev, 2024/06/30
- [PULL 01/16] hmp-commands-info.hx: Add missing info command for stats subcommand, Michael Tokarev, 2024/06/30
- [PULL 02/16] cpu: fix memleak of 'halt_cond' and 'thread', Michael Tokarev, 2024/06/30
- [PULL 04/16] target/i386: Advertise MWAIT iff host supports, Michael Tokarev, 2024/06/30
- [PULL 05/16] monitor: Remove obsolete stubs, Michael Tokarev, 2024/06/30
- [PULL 03/16] vl: Allow multiple -overcommit commands,
Michael Tokarev <=
- [PULL 06/16] linux-user: cris: Remove unused struct 'rt_signal_frame', Michael Tokarev, 2024/06/30
- [PULL 07/16] linux-user: sparc: Remove unused struct 'target_mc_fq', Michael Tokarev, 2024/06/30
- [PULL 08/16] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass', Michael Tokarev, 2024/06/30
- [PULL 09/16] net/can: Remove unused struct 'CanBusState', Michael Tokarev, 2024/06/30
- [PULL 10/16] os-posix: Expand setrlimit() syscall compatibility, Michael Tokarev, 2024/06/30
- [PULL 11/16] docs/cxl: fix some typos, Michael Tokarev, 2024/06/30
- [PULL 12/16] docs/system/devices/usb: Replace the non-existing "qemu" binary, Michael Tokarev, 2024/06/30
- [PULL 13/16] vl.c: select_machine(): use ERRP_GUARD instead of error propagation, Michael Tokarev, 2024/06/30
- [PULL 14/16] vl.c: select_machine(): use g_autoptr, Michael Tokarev, 2024/06/30
- [PULL 15/16] vl.c: select_machine(): add selected machine type to error message, Michael Tokarev, 2024/06/30